Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 1415923015: Downgrade lock icon for broken-HTTPS subresources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add MixedContentChecker unit test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index 6084b70661771dde3525ba9743f6887eeadef140..7b611a0c142f8286f67a67f507499388e8cf5246 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -34,6 +34,7 @@
#include "bindings/core/v8/ScriptController.h"
#include "core/dom/Document.h"
#include "core/fetch/ClientHintsPreferences.h"
+#include "core/fetch/ResourceLoader.h"
#include "core/fetch/UniqueIdentifier.h"
#include "core/frame/FrameConsole.h"
#include "core/frame/FrameHost.h"
@@ -237,6 +238,9 @@ void FrameFetchContext::dispatchDidReceiveResponse(unsigned long identifier, con
m_documentLoader->clientHintsPreferences().updateFromAcceptClientHintsHeader(response.httpHeaderField("accept-ch"), fetcher);
}
+ if (response.hasMajorCertificateErrors() && resourceLoader)
+ MixedContentChecker::handleCertificateError(MixedContentChecker::effectiveFrameForFrameType(frame(), resourceLoader->originalRequest().frameType()), response.url(), resourceLoader->originalRequest().requestContext(), resourceLoader->originalRequest().frameType(), response.getSecurityInfo());
Mike West 2015/11/27 05:30:38 Nit: This could be simpler to understand if you ju
estark 2015/11/28 02:46:56 Done.
+
frame()->loader().progress().incrementProgress(identifier, response);
frame()->loader().client()->dispatchDidReceiveResponse(m_documentLoader, identifier, response);
DocumentLoader* documentLoader = ensureLoaderForNotifications();

Powered by Google App Engine
This is Rietveld 408576698