Downgrade lock icon for broken-HTTPS subresources

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 501 matching lines @@
   void didReceiveResponse(blink::WebLocalFrame* frame,
                           unsigned identifier,
                           const blink::WebURLResponse& response) override;
   void didLoadResourceFromMemoryCache(
       blink::WebLocalFrame* frame,
       const blink::WebURLRequest& request,
       const blink::WebURLResponse& response) override;
   void didDisplayInsecureContent() override;
   void didRunInsecureContent(const blink::WebSecurityOrigin& origin,
                              const blink::WebURL& target) override;
+  void didDisplayContentWithCertificateErrors(
+      const blink::WebURL& url,
+      const blink::WebCString& security_info) override;

[jww, 2015/11/20 01:25:08]

Why are these WebCStrings instead of WebStrings? I don't see WebCStrings passed
around very much.

[estark, 2015/11/23 23:40:24]

I was going off of other APIs that expose security_info, which is an opaque
serialized blob of data, e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
and
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

I'm not sure why these existing APIs used WebCString though. Any thoughts?

[jww, 2015/11/25 19:24:02]

Nope, not really. Can you email chromium-dev or blink-dev to try and figure out
why we would use one over the other? I don't care too much, though, so we don't
need to block on that.

+  void didRunContentWithCertificateErrors(
+      const blink::WebSecurityOrigin& origin,
+      const blink::WebURL& url,
+      const blink::WebCString& security_info) override;
   void didChangePerformanceTiming() override;
   void didAbortLoading(blink::WebLocalFrame* frame) override;
   void didCreateScriptContext(blink::WebLocalFrame* frame,
                               v8::Local<v8::Context> context,
                               int extension_group,
                               int world_id) override;
   void willReleaseScriptContext(blink::WebLocalFrame* frame,
                                 v8::Local<v8::Context> context,
                                 int world_id) override;
   void didChangeScrollOffset(blink::WebLocalFrame* frame) override;
@@ skipping 570 matching lines @@
 #endif
 
   base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_