Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1415923012: Simple sharing and hoisting of final field loads (Closed)

Created:
5 years, 1 month ago by sra1
Modified:
5 years, 1 month ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simple sharing and hoisting of final field loads Final fields always yield the same value. Replace GetField operations with references to pevious in-scope GetField operations. If it is safe, hoist the GetField to the loop where the input is defined. This is a temporary pass while I continue on load elimination. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/cc0525c0c4828bd476d70c3aa1261d3c3fbc70b5

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -1 line) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/compiler/lib/src/cps_ir/share_final_fields.dart View 1 1 chunk +173 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
5 years, 1 month ago (2015-10-30 02:37:37 UTC) #3
asgerf
LGTM https://codereview.chromium.org/1415923012/diff/1/pkg/compiler/lib/src/cps_ir/share_final_fields.dart File pkg/compiler/lib/src/cps_ir/share_final_fields.dart (right): https://codereview.chromium.org/1415923012/diff/1/pkg/compiler/lib/src/cps_ir/share_final_fields.dart#newcode31 pkg/compiler/lib/src/cps_ir/share_final_fields.dart:31: final Map<Primitive, Interceptor> interceptorFor = <Primitive, Interceptor>{}; Unused ...
5 years, 1 month ago (2015-10-30 09:57:46 UTC) #4
sra1
5 years, 1 month ago (2015-10-30 18:36:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cc0525c0c4828bd476d70c3aa1261d3c3fbc70b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698