Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1415923003: Introduce WebMediaSession (Closed)

Created:
5 years, 2 months ago by davve
Modified:
5 years, 2 months ago
CC:
abarth-chromium, avayvod+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gavinp+loader_chromium.org, jam, Nate Chapin, loading-reviews_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-blink_chromium.org, nasko+codewatch_chromium.org, philipj_slow, posciak+watch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce WebMediaSession WebMediaSession is the API enabling web exposed MediaSession objects to control platform implementations of media session related functionality. Implementation will begin with Android and other platforms will be added later. Re-land of https://codereview.chromium.org/1370453002/ with https://code.google.com/p/chromium/issues/detail?id=546394 fixed. BUG=497735, 546394 Review URL: https://codereview.chromium.org/1370453002 Cr-Commit-Position: refs/heads/master@{#355058} Committed: https://crrev.com/50137b694146202f274c2d0f74d3c9ab4d228979 Cr-Commit-Position: refs/heads/master@{#355766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -17 lines) Patch
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A content/renderer/media/android/webmediasession_android.h View 1 chunk +27 lines, -0 lines 0 comments Download
A content/renderer/media/android/webmediasession_android.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +10 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/virtual/mediasession/media/mediasession/htmlmediaelement-set-session-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/virtual/mediasession/media/mediasession/mediasession-constructor-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/mediasession/media/mediasession/htmlmediaelement-set-session-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/mediasession/media/mediasession/mediasession-constructor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.h View 1 chunk +17 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 1 chunk +38 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.idl View 1 chunk +4 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/modules/mediasession/MediaSessionError.h View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediasession/MediaSessionError.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediasession/MediaSessionTest.cpp View 1 chunk +75 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/mediasession/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/mediasession/WebMediaSession.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/mediasession/WebMediaSessionError.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415923003/1
5 years, 2 months ago (2015-10-22 13:34:20 UTC) #2
davve
As written in the description, this is a re-upload of https://codereview.chromium.org/1370453002/ which was reverted because ...
5 years, 2 months ago (2015-10-22 15:23:54 UTC) #6
whywhat
lgtm
5 years, 2 months ago (2015-10-22 15:29:29 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 15:41:40 UTC) #9
philipj_slow
lgtm
5 years, 2 months ago (2015-10-23 08:35:12 UTC) #10
mlamouri (slow - plz ping)
still lgtm
5 years, 2 months ago (2015-10-23 09:56:54 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-23 12:07:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415923003/1
5 years, 2 months ago (2015-10-23 12:08:44 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 12:15:33 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 12:16:28 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50137b694146202f274c2d0f74d3c9ab4d228979
Cr-Commit-Position: refs/heads/master@{#355766}

Powered by Google App Engine
This is Rietveld 408576698