src/x64/lithium-x64.cc - Issue 14159028: Fixed an issue with HConstant::InNewSpace() for parallel compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 14159028: Fixed an issue with HConstant::InNewSpace() for parallel compilation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Be able to recognize if running on the optimizer thread Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index 4c5819076b913cbe0b3343b1aadba913bee6196e..dc74855e79d9bb302e8d4acc33bd8d083e9343a1 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -2246,7 +2246,7 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {

}

bool can_be_constant = instr->value()->IsConstant() &&

- !HConstant::cast(instr->value())->InNewSpace() &&

+ HConstant::cast(instr->value())->GuaranteedInOldSpace() &&

!(FLAG_track_double_fields && instr->field_representation().IsDouble());

LOperand* val;

« no previous file with comments | « src/optimizing-compiler-thread.cc ('k') | no next file » | no next file with comments »