Fixed an issue with HConstant::InNewSpace() for parallel compilation.

src/hydrogen-instructions.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2055 matching lines @@
   if (handle_->IsNumber()) {
     double n = handle_->Number();
     has_int32_value_ = IsInteger32(n);
     int32_value_ = DoubleToInt32(n);
     double_value_ = n;
     has_double_value_ = true;
   } else {
     type_from_value_ = HType::TypeFromValue(handle_);
     is_internalized_string_ = handle_->IsInternalizedString();
   }
+
   if (r.IsNone()) {
     if (has_int32_value_) {
       r = Representation::Integer32();
     } else if (has_double_value_) {
       r = Representation::Double();
     } else {
       r = Representation::Tagged();
     }
   }
   Initialize(r);
@@ skipping 49 matching lines @@
   Initialize(r);
 }
 
 
 void HConstant::Initialize(Representation r) {
   set_representation(r);
   SetFlag(kUseGVN);
   if (representation().IsInteger32()) {
     ClearGVNFlag(kDependsOnOsrEntries);
   }
+
+  // TODO(mvstanton): pass isolate as a parameter
+  Isolate* isolate = Isolate::Current();
+  if (handle_.is_null()) {
+    guaranteed_in_old_space_ = true;
+  } else if (!isolate->optimizing_compiler_thread()->IsOptimizerThread()) {
+    ALLOW_HANDLE_DEREF(isolate, "using raw address");
+    guaranteed_in_old_space_ = !(isolate->heap()->InNewSpace(*handle_));
+  } else {
+    guaranteed_in_old_space_ = false;
+  }
 }
 
 
 HConstant* HConstant::CopyToRepresentation(Representation r, Zone* zone) const {
   if (r.IsInteger32() && !has_int32_value_) return NULL;
   if (r.IsDouble() && !has_double_value_) return NULL;
-  if (has_int32_value_) return new(zone) HConstant(int32_value_, r, handle_);
-  if (has_double_value_) return new(zone) HConstant(double_value_, r, handle_);
-  ASSERT(!handle_.is_null());
-  return new(zone) HConstant(handle_,
-                             unique_id_,
-                             r,
-                             type_from_value_,
-                             is_internalized_string_,
-                             boolean_value_);
+  HConstant* result;
+  if (has_int32_value_) {
+    result = new(zone) HConstant(int32_value_, r, handle_);
+  } else if (has_double_value_) {
+    result = new(zone) HConstant(double_value_, r, handle_);
+  } else {
+    ASSERT(!handle_.is_null());
+    result = new(zone) HConstant(handle_,
+                                 unique_id_,
+                                 r,
+                                 type_from_value_,
+                                 is_internalized_string_,
+                                 boolean_value_);
+  }
+  result->set_guaranteed_in_old_space(guaranteed_in_old_space_);
+  return result;
 }
 
 
 HConstant* HConstant::CopyToTruncatedInt32(Zone* zone) const {
+  HConstant* result;
   if (has_int32_value_) {
-    return new(zone) HConstant(
+    result = new(zone) HConstant(
         int32_value_, Representation::Integer32(), handle_);
+  } else if (has_double_value_) {
+    result = new(zone) HConstant(
+        DoubleToInt32(double_value_), Representation::Integer32(), handle_);
+  } else {
+    return NULL;
   }
-  if (has_double_value_) {
-    return new(zone) HConstant(
-        DoubleToInt32(double_value_), Representation::Integer32(), handle_);
-  }
-  return NULL;
+
+  result->set_guaranteed_in_old_space(guaranteed_in_old_space_);
+  return result;
 }
 
 
 void HConstant::PrintDataTo(StringStream* stream) {
   if (has_int32_value_) {
     stream->Add("%d ", int32_value_);
   } else if (has_double_value_) {
     stream->Add("%f ", FmtElm(double_value_));
   } else {
     handle()->ShortPrint(stream);
@@ skipping 1444 matching lines @@
 
 
 void HCheckFunction::Verify() {
   HInstruction::Verify();
   ASSERT(HasNoUses());
 }
 
 #endif
 
 } }  // namespace v8::internal