Issue 14159015: MIPS: Improvements in lithium code generation. Recognizing if some operands are constants, we can o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14159015: MIPS: Improvements in lithium code generation. Recognizing if some operands are constants, we can o… (Closed)

Created:
7 years, 8 months ago by palfia

Modified:
7 years, 8 months ago

Reviewers:
kisg, Paul Lind, mvstanton, kilvadyb, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Improvements in lithium code generation. Recognizing if some operands are constants, we can often save on registers and instructions. Port r14364 (2819e5ee) BUG= Committed: https://code.google.com/p/v8/source/detail?r=14383

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -11 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View	1	1 chunk	+17 lines, -9 lines	0 comments	Download
	M	src/mips/lithium-mips.cc	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM modulo the nit. https://codereview.chromium.org/14159015/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/14159015/diff/1/src/mips/lithium-codegen-mips.cc#newcode2887 src/mips/lithium-codegen-mips.cc:2887: // Subtracting from length accounts ...

7 years, 8 months ago (2013-04-22 21:49:22 UTC) #2

Message was sent while issue was closed.

Committed manually as r14383 (presubmit successful).

Expand Messages | Collapse Messages