Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1415883011: Don't crash on error at end-of-file. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't crash on error at end-of-file. BUG= Committed: https://github.com/dart-lang/sdk/commit/d4021e92a184a3d1c7b644fe2c6de4cb7a445a38

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pkg/compiler/lib/src/io/source_file.dart View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
TBR
5 years, 1 month ago (2015-11-02 13:05:37 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as d4021e92a184a3d1c7b644fe2c6de4cb7a445a38 (presubmit successful).
5 years, 1 month ago (2015-11-02 13:06:07 UTC) #3
ahe
lgtm https://codereview.chromium.org/1415883011/diff/1/pkg/compiler/lib/src/io/source_file.dart File pkg/compiler/lib/src/io/source_file.dart (right): https://codereview.chromium.org/1415883011/diff/1/pkg/compiler/lib/src/io/source_file.dart#newcode140 pkg/compiler/lib/src/io/source_file.dart:140: if (end > length) { Add a TODO ...
5 years, 1 month ago (2015-11-02 16:55:31 UTC) #4
ahe
5 years, 1 month ago (2015-11-02 16:56:02 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1415883011/diff/1/pkg/compiler/lib/src/io/sou...
File pkg/compiler/lib/src/io/source_file.dart (right):

https://codereview.chromium.org/1415883011/diff/1/pkg/compiler/lib/src/io/sou...
pkg/compiler/lib/src/io/source_file.dart:140: if (end > length) {
On 2015/11/02 16:55:31, ahe wrote:
> Add a TODO to turn this into an assertion. If you get the wrong position from,
> for example, a patch file this could be very confusing.

I meant to say: "consider adding a TODO..."

Powered by Google App Engine
This is Rietveld 408576698