Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1415883007: [es6] Partially implement Reflect.set. (Closed)

Created:
5 years, 1 month ago by neis
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Partially implement Reflect.set. Proxies are not properly supported yet. R=rossberg BUG=v8:3931 LOG=n Committed: https://crrev.com/5820adf276e46ab75e84438ffbe3a017efee44fc Cr-Commit-Position: refs/heads/master@{#31685}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Oops. #

Patch Set 3 : More tests. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -3 lines) Patch
M src/bootstrapper.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/reflect.js View 1 2 3 2 chunks +144 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
neis
5 years, 1 month ago (2015-10-29 13:30:41 UTC) #1
rossberg
LGTM except for the deactivated test. https://codereview.chromium.org/1415883007/diff/1/test/mjsunit/harmony/reflect.js File test/mjsunit/harmony/reflect.js (right): https://codereview.chromium.org/1415883007/diff/1/test/mjsunit/harmony/reflect.js#newcode256 test/mjsunit/harmony/reflect.js:256: // assertFalse(Reflect.set({}, "bla", ...
5 years, 1 month ago (2015-10-29 16:38:25 UTC) #2
neis
On 2015/10/29 16:38:25, rossberg wrote: > LGTM except for the deactivated test. > > https://codereview.chromium.org/1415883007/diff/1/test/mjsunit/harmony/reflect.js ...
5 years, 1 month ago (2015-10-29 17:05:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415883007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415883007/60001
5 years, 1 month ago (2015-10-30 10:57:23 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-30 11:48:24 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 11:48:50 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5820adf276e46ab75e84438ffbe3a017efee44fc
Cr-Commit-Position: refs/heads/master@{#31685}

Powered by Google App Engine
This is Rietveld 408576698