Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2156)

Issue 1415873007: Fixed minor memory leak in framebuffer attachments. (Closed)

Created:
5 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 1 month ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, blink-reviews, qiankun
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed minor memory leak in framebuffer attachments. Renderbuffers and texture attachments to framebuffer objects overwrite each other, and so should the links that preserve their JavaScript wrappers. This is difficult to test because there's no guarantee of prompt reclamation. Ensured expando-loss.html test still runs. BUG=547946 Committed: https://crrev.com/e473a2d937f3ded6565367a9c00f89fc4e6e90ff Cr-Commit-Position: refs/heads/master@{#356189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Russell (switch to Gerrit)
PTAL. Please CQ if this looks OK to you. Thanks.
5 years, 1 month ago (2015-10-26 21:20:06 UTC) #2
Zhenyao Mo
LGTM
5 years, 1 month ago (2015-10-26 22:03:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415873007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415873007/1
5 years, 1 month ago (2015-10-26 22:05:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 00:05:53 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 00:06:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e473a2d937f3ded6565367a9c00f89fc4e6e90ff
Cr-Commit-Position: refs/heads/master@{#356189}

Powered by Google App Engine
This is Rietveld 408576698