Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415873002: Measure usage of the HTMLFieldSetElement.elements element (Closed)

Created:
5 years, 2 months ago by philipj_slow
Modified:
5 years, 2 months ago
Reviewers:
tkent, rkaplow, Mark P
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, Inactive, chromium-reviews, dglazkov+blink, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure usage of the HTMLFieldSetElement.elements element This will likely be made an HTMLCollection in the spec: https://github.com/whatwg/html/issues/200 Knowing the usage will give some clue about the risk of the change. R=tkent@chromium.org Committed: https://crrev.com/b934011e1802882755790b423082a3c20a2dfc9b Cr-Commit-Position: refs/heads/master@{#355522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
philipj_slow
5 years, 2 months ago (2015-10-20 12:58:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415873002/1
5 years, 2 months ago (2015-10-20 12:58:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 14:07:40 UTC) #5
tkent
lgtm
5 years, 2 months ago (2015-10-20 22:51:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415873002/1
5 years, 2 months ago (2015-10-21 09:32:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/111342)
5 years, 2 months ago (2015-10-21 09:39:58 UTC) #10
philipj_slow
rkaplow@, mpearson@, can you please review the histograms change?
5 years, 2 months ago (2015-10-21 10:27:34 UTC) #12
rkaplow
lgtm
5 years, 2 months ago (2015-10-21 14:43:18 UTC) #13
Mark P
histograms.xml lgtm
5 years, 2 months ago (2015-10-21 19:15:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415873002/1
5 years, 2 months ago (2015-10-22 07:13:13 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 10:27:51 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 10:28:52 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b934011e1802882755790b423082a3c20a2dfc9b
Cr-Commit-Position: refs/heads/master@{#355522}

Powered by Google App Engine
This is Rietveld 408576698