Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1415863003: Add OWNERS files to src/crankshaft/ (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add OWNERS files to src/crankshaft/ NOTRY=true Committed: https://crrev.com/af0a228d9003278dac309c3872a5e0ae04bce00f Cr-Commit-Position: refs/heads/master@{#31457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, --4 lines) Patch
A + src/crankshaft/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/crankshaft/arm/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/crankshaft/arm64/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/crankshaft/mips/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/crankshaft/mips64/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/crankshaft/ppc/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/crankshaft/x87/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jakob Kummerow
As a proposal, I've picked a selection of people who have worked on Crankshaft in ...
5 years, 2 months ago (2015-10-20 14:00:11 UTC) #2
Benedikt Meurer
LGTM from my side.
5 years, 2 months ago (2015-10-20 14:00:48 UTC) #3
Jarin
lgtm.
5 years, 2 months ago (2015-10-20 14:08:48 UTC) #4
Toon Verwaest
lgtm
5 years, 2 months ago (2015-10-20 15:26:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415863003/1
5 years, 2 months ago (2015-10-22 09:04:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 09:06:15 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 09:06:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af0a228d9003278dac309c3872a5e0ae04bce00f
Cr-Commit-Position: refs/heads/master@{#31457}

Powered by Google App Engine
This is Rietveld 408576698