Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1415863002: Delete all cached ephemeral apps at startup. (Closed)

Created:
5 years, 2 months ago by benwells
Modified:
5 years, 1 month ago
Reviewers:
Devlin
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete all cached ephemeral apps at startup. Ephemeral apps were cached when downloaded. The ephemeral app service managed this cache, uninstalling old apps when the cache got full etc. It also disabled ephemeral apps when they weren't running. This change removes most of the ephemeral app service, and replaces it with a simple implementation that deletes all cached apps at startup. Some code to disable after they are stopped is left to keep the existing tests passing. Once the code to delete all cached ephemeral apps has been in stable for a milestone, the remaining bits of the ephemeral app system will be removed. BUG=517735 Committed: https://crrev.com/59617d988124e582906ac72c2357738307f2e645 Cr-Commit-Position: refs/heads/master@{#357008}

Patch Set 1 #

Patch Set 2 : Remove dud file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -694 lines) Patch
M chrome/browser/apps/ephemeral_app_service.h View 4 chunks +2 lines, -35 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service.cc View 10 chunks +8 lines, -219 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service_browsertest.cc View 2 chunks +11 lines, -173 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service_unittest.cc View 1 1 chunk +0 lines, -266 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
benwells
5 years, 2 months ago (2015-10-21 03:31:47 UTC) #2
Devlin
Sorry for the delay; not sure how this one slipped through. LGTM
5 years, 1 month ago (2015-10-29 21:36:14 UTC) #3
benwells
On 2015/10/29 21:36:14, Devlin wrote: > Sorry for the delay; not sure how this one ...
5 years, 1 month ago (2015-10-30 00:29:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415863002/20001
5 years, 1 month ago (2015-10-30 00:30:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 01:20:19 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 01:21:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59617d988124e582906ac72c2357738307f2e645
Cr-Commit-Position: refs/heads/master@{#357008}

Powered by Google App Engine
This is Rietveld 408576698