Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1415843008: Revert "Remove deprecated dart:profiler library" (Closed)

Created:
5 years, 1 month ago by floitsch
Modified:
5 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove deprecated dart:profiler library" This reverts commit 535a9715ac9e8506e8fc6e9b274a1e0955738060. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/be025b841211c5589f162e206160e656c81a8f83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -10 lines) Patch
A + runtime/lib/profiler_sources.gypi View 1 chunk +2 lines, -7 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/bootstrap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/object_store.h View 4 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/vm.gypi View 4 chunks +43 lines, -0 lines 0 comments Download
A sdk/lib/profiler/profiler.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A + sdk/lib/profiler/profiler_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 1 month ago (2015-11-04 00:43:02 UTC) #2
Cutch
lgtm
5 years, 1 month ago (2015-11-04 00:49:27 UTC) #3
floitsch
5 years, 1 month ago (2015-11-04 00:59:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be025b841211c5589f162e206160e656c81a8f83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698