Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1415833002: [turbofan] Alternative splintering mechanism. (Closed)

Created:
5 years, 2 months ago by Mircea Trofin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Instead of splintering by chunks of deferred blocks, irrespective of the range's internal structure, we take a range at a time and splinter based on the blocks it covers. This is no different in scenarios where a UseInterval covers non-deferred then deferred blocks. However, in scenarios where a deferred block jumps to another one, and there are no other blocks covered by the range in between, this CL will treat the two such blocks together, while the previous one would treat them separately. This matters in cases such as deoptimization blocks preceded (not necessarily consecutively) by a single instruction (jump) Merging block. Committed: https://crrev.com/27f51390e9e2a1bdf72783ebe2407045815c5ee9 Cr-Commit-Position: refs/heads/master@{#31422}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -83 lines) Patch
M src/compiler/live-range-separator.cc View 1 2 3 4 2 chunks +61 lines, -83 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
5 years, 2 months ago (2015-10-20 06:06:11 UTC) #3
Jarin
lgtm with nits. https://codereview.chromium.org/1415833002/diff/80001/src/compiler/live-range-separator.cc File src/compiler/live-range-separator.cc (right): https://codereview.chromium.org/1415833002/diff/80001/src/compiler/live-range-separator.cc#newcode60 src/compiler/live-range-separator.cc:60: if (!(start.IsGapPosition() || start.IsStart())) { I ...
5 years, 2 months ago (2015-10-20 13:12:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415833002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415833002/100001
5 years, 2 months ago (2015-10-20 15:56:33 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 2 months ago (2015-10-20 16:00:25 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 16:00:46 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/27f51390e9e2a1bdf72783ebe2407045815c5ee9
Cr-Commit-Position: refs/heads/master@{#31422}

Powered by Google App Engine
This is Rietveld 408576698