Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: src/hydrogen.cc

Issue 141583011: Kill obsolete HLoadExternalArrayPointer instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2103 matching lines...) Expand 10 before | Expand all | Expand 10 after
2114 checked_object, HObjectAccess::ForArrayLength(elements_kind)); 2114 checked_object, HObjectAccess::ForArrayLength(elements_kind));
2115 } else { 2115 } else {
2116 length = AddLoadFixedArrayLength(elements); 2116 length = AddLoadFixedArrayLength(elements);
2117 } 2117 }
2118 length->set_type(HType::Smi()); 2118 length->set_type(HType::Smi());
2119 HValue* checked_key = NULL; 2119 HValue* checked_key = NULL;
2120 if (IsExternalArrayElementsKind(elements_kind) || 2120 if (IsExternalArrayElementsKind(elements_kind) ||
2121 IsFixedTypedArrayElementsKind(elements_kind)) { 2121 IsFixedTypedArrayElementsKind(elements_kind)) {
2122 HValue* backing_store; 2122 HValue* backing_store;
2123 if (IsExternalArrayElementsKind(elements_kind)) { 2123 if (IsExternalArrayElementsKind(elements_kind)) {
2124 backing_store = 2124 backing_store = Add<HLoadNamedField>(
2125 Add<HLoadExternalArrayPointer>(elements); 2125 elements, HObjectAccess::ForExternalArrayExternalPointer());
2126 } else { 2126 } else {
2127 backing_store = elements; 2127 backing_store = elements;
2128 } 2128 }
2129 if (store_mode == STORE_NO_TRANSITION_IGNORE_OUT_OF_BOUNDS) { 2129 if (store_mode == STORE_NO_TRANSITION_IGNORE_OUT_OF_BOUNDS) {
2130 NoObservableSideEffectsScope no_effects(this); 2130 NoObservableSideEffectsScope no_effects(this);
2131 IfBuilder length_checker(this); 2131 IfBuilder length_checker(this);
2132 length_checker.If<HCompareNumericAndBranch>(key, length, Token::LT); 2132 length_checker.If<HCompareNumericAndBranch>(key, length, Token::LT);
2133 length_checker.Then(); 2133 length_checker.Then();
2134 IfBuilder negative_checker(this); 2134 IfBuilder negative_checker(this);
2135 HValue* bounds_check = negative_checker.If<HCompareNumericAndBranch>( 2135 HValue* bounds_check = negative_checker.If<HCompareNumericAndBranch>(
(...skipping 8988 matching lines...) Expand 10 before | Expand all | Expand 10 after
11124 if (ShouldProduceTraceOutput()) { 11124 if (ShouldProduceTraceOutput()) {
11125 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 11125 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
11126 } 11126 }
11127 11127
11128 #ifdef DEBUG 11128 #ifdef DEBUG
11129 graph_->Verify(false); // No full verify. 11129 graph_->Verify(false); // No full verify.
11130 #endif 11130 #endif
11131 } 11131 }
11132 11132
11133 } } // namespace v8::internal 11133 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698