Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 141583011: Kill obsolete HLoadExternalArrayPointer instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3129 matching lines...) Expand 10 before | Expand all | Expand 10 after
3140 __ bind(&done); 3140 __ bind(&done);
3141 } 3141 }
3142 3142
3143 3143
3144 void LCodeGen::DoLoadRoot(LLoadRoot* instr) { 3144 void LCodeGen::DoLoadRoot(LLoadRoot* instr) {
3145 Register result = ToRegister(instr->result()); 3145 Register result = ToRegister(instr->result());
3146 __ LoadRoot(result, instr->index()); 3146 __ LoadRoot(result, instr->index());
3147 } 3147 }
3148 3148
3149 3149
3150 void LCodeGen::DoLoadExternalArrayPointer(
3151 LLoadExternalArrayPointer* instr) {
3152 Register to_reg = ToRegister(instr->result());
3153 Register from_reg = ToRegister(instr->object());
3154 __ ldr(to_reg, FieldMemOperand(from_reg,
3155 ExternalArray::kExternalPointerOffset));
3156 }
3157
3158
3159 void LCodeGen::DoAccessArgumentsAt(LAccessArgumentsAt* instr) { 3150 void LCodeGen::DoAccessArgumentsAt(LAccessArgumentsAt* instr) {
3160 Register arguments = ToRegister(instr->arguments()); 3151 Register arguments = ToRegister(instr->arguments());
3161 Register result = ToRegister(instr->result()); 3152 Register result = ToRegister(instr->result());
3162 // There are two words between the frame pointer and the last argument. 3153 // There are two words between the frame pointer and the last argument.
3163 // Subtracting from length accounts for one of them add one more. 3154 // Subtracting from length accounts for one of them add one more.
3164 if (instr->length()->IsConstantOperand()) { 3155 if (instr->length()->IsConstantOperand()) {
3165 int const_length = ToInteger32(LConstantOperand::cast(instr->length())); 3156 int const_length = ToInteger32(LConstantOperand::cast(instr->length()));
3166 if (instr->index()->IsConstantOperand()) { 3157 if (instr->index()->IsConstantOperand()) {
3167 int const_index = ToInteger32(LConstantOperand::cast(instr->index())); 3158 int const_index = ToInteger32(LConstantOperand::cast(instr->index()));
3168 int index = (const_length - const_index) + 1; 3159 int index = (const_length - const_index) + 1;
(...skipping 2649 matching lines...) Expand 10 before | Expand all | Expand 10 after
5818 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5809 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5819 __ ldr(result, FieldMemOperand(scratch, 5810 __ ldr(result, FieldMemOperand(scratch,
5820 FixedArray::kHeaderSize - kPointerSize)); 5811 FixedArray::kHeaderSize - kPointerSize));
5821 __ bind(&done); 5812 __ bind(&done);
5822 } 5813 }
5823 5814
5824 5815
5825 #undef __ 5816 #undef __
5826 5817
5827 } } // namespace v8::internal 5818 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698