Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 141583011: Kill obsolete HLoadExternalArrayPointer instruction. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Kill obsolete HLoadExternalArrayPointer instruction. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -160 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -33 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
No comment.
6 years, 10 months ago (2014-01-28 20:47:34 UTC) #1
Sven Panne
lgtm
6 years, 10 months ago (2014-01-29 07:13:17 UTC) #2
Benedikt Meurer
6 years, 10 months ago (2014-01-29 07:27:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18893 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698