Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415823003: OrdinaryDefineOwnProperty: always reset the LookupIterator before storing. (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow
Modified:
5 years, 2 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

OrdinaryDefineOwnProperty: always reset the LookupIterator before storing. Committed: https://crrev.com/7bc5ce16ee9244869384cdf17ea2feb0a9dde9bd Cr-Commit-Position: refs/heads/master@{#31511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/objects.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
5 years, 2 months ago (2015-10-23 09:58:16 UTC) #2
Camillo Bruni
lgtm
5 years, 2 months ago (2015-10-23 09:59:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415823003/1
5 years, 2 months ago (2015-10-23 09:59:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 10:47:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7bc5ce16ee9244869384cdf17ea2feb0a9dde9bd Cr-Commit-Position: refs/heads/master@{#31511}
5 years, 2 months ago (2015-10-23 10:48:35 UTC) #7
Michael Hablich
5 years, 2 months ago (2015-10-23 19:20:31 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1418303002/ by hablich@chromium.org.

The reason for reverting is: Breaks test if rolled into Chromium:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20....

Powered by Google App Engine
This is Rietveld 408576698