XFA: add CPDFDocumentToFPDFDocument()

XFA: add CPDFDocumentToFPDFDocument()

Abstracts away that master returns CPDF_Documents directly,
but XFA wraps them with a CPDFXFA_Document.

Tidy dead code along the way.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/bf59a070593d079256161f6ff47148df309668c7

[Tom Sepez, 2015-10-20 22:07:46]

Description was changed from

==========
Bring XFA along.

BUG=
==========

to

==========
XFA: add CPDFDocumentToFPDFDocument()

Abstracts away that master returns CPDF_Documents direclty,
but XFA wraps them with a CPDFXFA_Document.

Tidy dead code along the way.
==========

[Tom Sepez, 2015-10-20 22:07:46]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-10-20 23:02:52]

Lei, for review.  There will be a corresponding master side patch that simply
casts the result.

[Lei Zhang, 2015-10-20 23:56:48]

Looking....

typo: direclty

[Lei Zhang, 2015-10-21 00:12:58]

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/include/fsdk_ba...
File fpdfsdk/include/fsdk_baseform.h (right):

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/include/fsdk_ba...
fpdfsdk/include/fsdk_baseform.h:206: mutable IXFA_Widget* m_hMixXFAWidget;
What's the mutable for?

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/include/fsdk_de...
File fpdfsdk/include/fsdk_define.h (right):

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/include/fsdk_de...
fpdfsdk/include/fsdk_define.h:92: FPDF_DOCUMENT
CPDFDocumentToFDPFDocument(CPDF_Document* doc);
Or make this FDPFDocumentFromCPDFDocument ?

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/src/fpdfxfa/fpd...
File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/src/fpdfxfa/fpd...
fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:643: else if (fileType == FXFA_SAVEAS_XDP) {
combine with previous line

[Tom Sepez, 2015-10-21 20:09:34]

Description was changed from

==========
XFA: add CPDFDocumentToFPDFDocument()

Abstracts away that master returns CPDF_Documents direclty,
but XFA wraps them with a CPDFXFA_Document.

Tidy dead code along the way.
==========

to

==========
XFA: add CPDFDocumentToFPDFDocument()

Abstracts away that master returns CPDF_Documents directly,
but XFA wraps them with a CPDFXFA_Document.

Tidy dead code along the way.
==========

[Tom Sepez, 2015-10-21 20:09:43]

On 2015/10/20 23:56:48, Lei Zhang wrote:
> Looking....
> 
> typo: direclty

Done.

[Tom Sepez, 2015-10-21 20:40:55]

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/include/fsdk_ba...
File fpdfsdk/include/fsdk_baseform.h (right):

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/include/fsdk_ba...
fpdfsdk/include/fsdk_baseform.h:206: mutable IXFA_Widget* m_hMixXFAWidget;
On 2015/10/21 00:12:57, Lei Zhang wrote:
> What's the mutable for?

CPDFSDK_Widget::GetMixXFAWidget() caches the result of its computation in
m_hMixXFAWidget, and returns it each time so that it's logically const but not
actually so.

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/include/fsdk_de...
File fpdfsdk/include/fsdk_define.h (right):

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/include/fsdk_de...
fpdfsdk/include/fsdk_define.h:92: FPDF_DOCUMENT
CPDFDocumentToFDPFDocument(CPDF_Document* doc);
On 2015/10/21 00:12:57, Lei Zhang wrote:
> Or make this FDPFDocumentFromCPDFDocument.
Done.

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/src/fpdfxfa/fpd...
File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1415803002/diff/40001/fpdfsdk/src/fpdfxfa/fpd...
fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:643: else if (fileType == FXFA_SAVEAS_XDP) {
On 2015/10/21 00:12:57, Lei Zhang wrote:
> combine with previous line

Done.

[Lei Zhang, 2015-10-21 20:46:16]

lgtm

[Tom Sepez, 2015-10-21 21:07:29]

Committed patchset #4 (id:60001) manually as
bf59a070593d079256161f6ff47148df309668c7 (presubmit successful).