Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 14158015: Allow supporting older PICTURE_VERSIONs. (Closed)

Created:
7 years, 7 months ago by scroggo
Modified:
7 years, 7 months ago
Reviewers:
rmistry, djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Allow supporting 1 older PICTURE_VERSION. Allows https://codereview.chromium.org/14230022/ to be submitted without breaking bench_pictures and render_pictures. After DEPS roll and SKP capture, this will be reverted. Committed: https://code.google.com/p/skia/source/detail?r=8918

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -38 lines) Patch
M include/core/SkPicture.h View 2 chunks +1 line, -1 line 0 comments Download
M src/core/SkOrderedReadBuffer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/core/SkOrderedReadBuffer.cpp View 4 chunks +74 lines, -35 lines 6 comments Download
M src/core/SkPicture.cpp View 2 chunks +6 lines, -2 lines 1 comment Download
M src/core/SkPicturePlayback.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
https://codereview.chromium.org/14158015/diff/1/src/core/SkOrderedReadBuffer.cpp File src/core/SkOrderedReadBuffer.cpp (right): https://codereview.chromium.org/14158015/diff/1/src/core/SkOrderedReadBuffer.cpp#newcode180 src/core/SkOrderedReadBuffer.cpp:180: if (10 == fPictureVersion) { codereview makes this unobvious, ...
7 years, 7 months ago (2013-04-29 18:50:41 UTC) #1
scroggo
https://codereview.chromium.org/14158015/diff/1/src/core/SkPicture.cpp File src/core/SkPicture.cpp (right): https://codereview.chromium.org/14158015/diff/1/src/core/SkPicture.cpp#newcode290 src/core/SkPicture.cpp:290: if (info.fVersion < 10 || info.fVersion > PICTURE_VERSION) { ...
7 years, 7 months ago (2013-04-29 19:00:40 UTC) #2
scroggo
As requested, this CL goes on top of https://codereview.chromium.org/14230022/ so that we can avoid making ...
7 years, 7 months ago (2013-04-29 20:51:20 UTC) #3
scroggo
7 years, 7 months ago (2013-04-30 02:38:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r8918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698