Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: runtime/vm/os_win.cc

Issue 14158012: Align code by 32 bytes to reduce benchmark flakiness on Intel CPUs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/os_linux.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_OS_WINDOWS) 6 #if defined(TARGET_OS_WINDOWS)
7 7
8 #include "vm/os.h" 8 #include "vm/os.h"
9 #include "vm/vtune.h" 9 #include "vm/vtune.h"
10 10
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 // Windows 64-bit ABI requires the stack to be 16-byte aligned. 130 // Windows 64-bit ABI requires the stack to be 16-byte aligned.
131 return 16; 131 return 16;
132 #else 132 #else
133 // No requirements on Win32. 133 // No requirements on Win32.
134 return 0; 134 return 0;
135 #endif 135 #endif
136 } 136 }
137 137
138 138
139 word OS::PreferredCodeAlignment() { 139 word OS::PreferredCodeAlignment() {
140 ASSERT(16 <= OS::kMaxPreferredCodeAlignment); 140 ASSERT(32 <= OS::kMaxPreferredCodeAlignment);
141 return 16; 141 return 32;
142 } 142 }
143 143
144 144
145 uword OS::GetStackSizeLimit() { 145 uword OS::GetStackSizeLimit() {
146 // TODO(ager): Can you programatically determine the actual stack 146 // TODO(ager): Can you programatically determine the actual stack
147 // size limit on Windows? The 2MB limit is set at link time. Maybe 147 // size limit on Windows? The 2MB limit is set at link time. Maybe
148 // that value should be propagated here? 148 // that value should be propagated here?
149 return 2 * MB; 149 return 2 * MB;
150 } 150 }
151 151
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 } 306 }
307 307
308 308
309 void OS::Exit(int code) { 309 void OS::Exit(int code) {
310 exit(code); 310 exit(code);
311 } 311 }
312 312
313 } // namespace dart 313 } // namespace dart
314 314
315 #endif // defined(TARGET_OS_WINDOWS) 315 #endif // defined(TARGET_OS_WINDOWS)
OLDNEW
« no previous file with comments | « runtime/vm/os_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698