Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 14158006: Capture receiver in generator object (Closed)

Created:
7 years, 8 months ago by wingo
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
rossberg
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Capture receiver in generator object Previously there has been no reason to context-allocate the receiver, so access to the receiver always goes through the stack. This was failing with generators, which assumed that forcing context allocation would relieve the need of storing anything but the context and the function on the stack. This CL adds a slot in generator objects to capture the receiver, and restores it when resuming a generator. BUG=v8:2355 TEST=mjsunit/harmony/generators-iteration Committed: http://code.google.com/p/v8/source/detail?r=14434

Patch Set 1 #

Patch Set 2 : Rebase on master, fix for ARM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -39 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/generators-iteration.js View 1 chunk +20 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
This CL fixes access to "this" within a generator.
7 years, 8 months ago (2013-04-23 14:41:55 UTC) #1
wingo
Updated CL adapts to ARM fixes and is ready to go.
7 years, 8 months ago (2013-04-25 07:51:39 UTC) #2
Michael Starzinger
LGTM. I'll land this.
7 years, 8 months ago (2013-04-25 10:43:05 UTC) #3
Michael Starzinger
7 years, 8 months ago (2013-04-25 10:59:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698