fix build when ffmpeg, libvpx and libwebm are disabled

content/renderer/media/media_recorder_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_recorder_handler.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "content/renderer/media/video_track_recorder.h"
@@ skipping 60 matching lines @@
 }
 
 bool MediaRecorderHandler::start(int timeslice) {
   DCHECK(main_render_thread_checker_.CalledOnValidThread());
   DCHECK(!recording_);
   DCHECK(!media_stream_.isNull());
   DCHECK(!webm_muxer_);
   DCHECK(timeslice_.is_zero());
 
   timeslice_ = TimeDelta::FromMilliseconds(timeslice);
   slice_origin_timestamp_ = TimeTicks::Now();

[xhwang, 2015/11/02 18:11:51]

Move these two lines to below l.83 as well.

[Julien Isorce Samsung, 2015/11/03 16:02:27]

ok, I see it will still work since ::start and ::WriteData are called in the
same thread. (so the 2 calls are serialized and slice_origin_timestamp_ will be
up to date at the time ::WriteData is called)

 
+#if !defined(MEDIA_DISABLE_LIBWEBM)

[xhwang, 2015/11/02 18:11:51]

+mcasas: shouldn't we exclude media_recorder_hander.cc entirely if
!defined(MEDIA_DISABLE_LIBWEBM)?

[Julien Isorce Samsung, 2015/11/03 16:02:27]

I'll let mcasas decide but I think not disabling media recorder entirely let
someone provides an alternative impl if not using libwebm. 

   webm_muxer_.reset(

[xhwang, 2015/11/02 18:11:51]

Do you need to fix the header file as well?

[Julien Isorce Samsung, 2015/11/03 16:02:27]

Yes I will add the guard. Thx

       new media::WebmMuxer(use_vp9_ ? media::kCodecVP9 : media::kCodecVP8,
                            base::Bind(&MediaRecorderHandler::WriteData,
                                       weak_factory_.GetWeakPtr())));
+#else
+  return false;
+#endif
 
   blink::WebVector<blink::WebMediaStreamTrack> video_tracks;
   media_stream_.videoTracks(video_tracks);
 
   if (video_tracks.isEmpty()) {
     // TODO(mcasas): Add audio_tracks and update the code in this function
     // correspondingly, see http://crbug.com/528519. As of now, only video
     // tracks are supported.
     LOG(WARNING) << "Recording no video tracks is not implemented";
     return false;
@@ skipping 45 matching lines @@
 }
 
 void MediaRecorderHandler::OnEncodedVideo(
     const scoped_refptr<media::VideoFrame>& video_frame,
     scoped_ptr<std::string> encoded_data,
     TimeTicks timestamp,
     bool is_key_frame) {
   DCHECK(main_render_thread_checker_.CalledOnValidThread());
   if (!webm_muxer_)
     return;
+#if !defined(MEDIA_DISABLE_LIBWEBM)
   webm_muxer_->OnEncodedVideo(video_frame, encoded_data.Pass(), timestamp,
                               is_key_frame);
+#endif
 }
 
 void MediaRecorderHandler::WriteData(base::StringPiece data) {
   DCHECK(main_render_thread_checker_.CalledOnValidThread());
 
   // Non-buffered mode does not need to check timestamps.
   if (timeslice_.is_zero()) {
     client_->writeData(data.data(), data.length(), true  /* lastInSlice */);
     return;
   }
 
   const TimeTicks now = TimeTicks::Now();
   const bool last_in_slice = now > slice_origin_timestamp_ + timeslice_;
   DVLOG_IF(1, last_in_slice) << "Slice finished @ " << now;
   if (last_in_slice)
     slice_origin_timestamp_ = now;
   client_->writeData(data.data(), data.length(), last_in_slice);
 }
 
 void MediaRecorderHandler::OnVideoFrameForTesting(
     const scoped_refptr<media::VideoFrame>& frame,
     const TimeTicks& timestamp) {
   for (auto* recorder : video_recorders_)
     recorder->OnVideoFrameForTesting(frame, timestamp);
 }
 
 }  // namespace content