fix build when ffmpeg, libvpx and libwebm are disabled

chrome/utility/extensions/extensions_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/extensions/extensions_handler.h"
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "chrome/common/chrome_utility_messages.h"
 #include "chrome/common/extensions/chrome_extensions_client.h"
 #include "chrome/common/extensions/chrome_utility_extensions_messages.h"
 #include "chrome/common/media_galleries/metadata_types.h"
 #include "chrome/utility/chrome_content_utility_client.h"
 #include "chrome/utility/media_galleries/image_metadata_extractor.h"
 #include "chrome/utility/media_galleries/ipc_data_source.h"
 #include "chrome/utility/media_galleries/media_metadata_parser.h"
 #include "content/public/common/content_paths.h"
 #include "content/public/utility/utility_thread.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_l10n_util.h"
 #include "extensions/common/extension_utility_messages.h"
 #include "extensions/utility/unpacker.h"
 #include "media/base/media.h"
 #include "media/base/media_file_checker.h"

[xhwang, 2015/11/02 18:11:51]

Move this to ifdef MEDIA_DISABLE_FFMPEG as well.

[Julien Isorce Samsung, 2015/11/03 16:02:27]

Acknowledged.

[xhwang, 2015/11/05 17:27:17]

tip: Use "Done" when it's done :)

 #include "ui/base/ui_base_switches.h"
 
 #if defined(OS_WIN)
 #include "chrome/common/extensions/api/networking_private/networking_private_crypto.h"
 #include "chrome/utility/media_galleries/itunes_pref_parser_win.h"
 #include "components/wifi/wifi_service.h"
 #endif  // defined(OS_WIN)
 
 #if defined(OS_MACOSX)
 #include "chrome/utility/media_galleries/iphoto_library_parser.h"
@@ skipping 78 matching lines @@
 #endif  // defined(OS_WIN)
 
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled || utility_handler_.OnMessageReceived(message);
 }
 
 void ExtensionsHandler::OnCheckMediaFile(
     int64 milliseconds_of_decoding,
     const IPC::PlatformFileForTransit& media_file) {
+#if !defined(MEDIA_DISABLE_FFMPEG)
   media::MediaFileChecker checker(
       IPC::PlatformFileForTransitToFile(media_file));
   const bool check_success = checker.Start(
       base::TimeDelta::FromMilliseconds(milliseconds_of_decoding));
   Send(new ChromeUtilityHostMsg_CheckMediaFile_Finished(check_success));
+#else
+  Send(new ChromeUtilityHostMsg_CheckMediaFile_Finished(false));

[xhwang, 2015/11/02 18:11:51]

I suppose we'll never reach here (since nobody complaints so far), maybe
NOTREACHED()? +Reilly Grant

[Julien Isorce Samsung, 2015/11/03 16:02:27]

You are right, I'll add NOTREACHED() so that it won't be silent if actually
reached.

+#endif
   ReleaseProcessIfNeeded();
 }
 
 void ExtensionsHandler::OnParseMediaMetadata(
     const std::string& mime_type, int64 total_size, bool get_attached_images) {
   // Only one IPCDataSource may be created and added to the list of handlers.
   scoped_ptr<metadata::IPCDataSource> source(
       new metadata::IPCDataSource(total_size));
   metadata::MediaMetadataParser* parser = new metadata::MediaMetadataParser(
       source.get(), mime_type, get_attached_images);
@@ skipping 76 matching lines @@
 
   std::string key_data;
   std::string error;
   wifi_service->GetKeyFromSystem(network_guid, &key_data, &error);
 
   Send(new ChromeUtilityHostMsg_GotWiFiCredentials(key_data, error.empty()));
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace extensions