Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1415783006: Revert of [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. (Closed)

Created:
5 years, 1 month ago by Camillo Bruni
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. (patchset #20 id:370001 of https://codereview.chromium.org/1418623007/ ) Reason for revert: failing build bot Original issue's description: > [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. > > The current implementation of classes throws the TypeError at the wrong > point, after activating a new context when directly calling a class > constructor. According to the spec, the TypeError has to be thrown > in the caller context. > > LOG=N > BUG=v8:4428 > > Committed: https://crrev.com/6a06bc0a774933719f62009d81b3f1686d83bb90 > Cr-Commit-Position: refs/heads/master@{#31786} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4428 Committed: https://crrev.com/f1bb688e805c2c29c4c275bacc153b9860fe9288 Cr-Commit-Position: refs/heads/master@{#31787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -445 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +4 lines, -17 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +1 line, -29 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +5 lines, -20 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +1 line, -40 lines 0 comments Download
M src/globals.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +4 lines, -17 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +3 lines, -31 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +3 lines, -18 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +1 line, -28 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +3 lines, -18 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +2 lines, -28 lines 0 comments Download
M src/objects.h View 5 chunks +34 lines, -47 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +4 lines, -16 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 5 chunks +8 lines, -40 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +49 lines, -37 lines 0 comments Download
M test/mjsunit/array-iteration.js View 4 chunks +9 lines, -27 lines 0 comments Download
M test/mjsunit/es6/classes.js View 1 chunk +0 lines, -25 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Camillo Bruni
Created Revert of [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor.
5 years, 1 month ago (2015-11-04 13:55:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415783006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415783006/1
5 years, 1 month ago (2015-11-04 13:55:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 13:56:20 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 13:56:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1bb688e805c2c29c4c275bacc153b9860fe9288
Cr-Commit-Position: refs/heads/master@{#31787}

Powered by Google App Engine
This is Rietveld 408576698