Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: BUILD.gn

Issue 1415783003: Add more test binaries to GN Mac build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 6b682d820c3c4d20fef1f181769b14b5f12ce7d7..3ebac8165184050f8527fbe04cd22b2ac6fa3e31 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -534,20 +534,13 @@ group("both_gn_and_gyp") {
"//chrome/test:interactive_ui_tests", # TODO(GYP)
"//chrome/test:sync_integration_tests", # TODO(GYP)
"//chrome/test:unit_tests", # TODO(GYP)
- "//components:components_browsertests", # TODO(GYP)
- "//components:components_unittests", # TODO(GYP)
"//content/test:content_browsertests", # TODO(GYP)
"//content/test:content_perftests", # TODO(GYP)
- "//device:device_unittests", # TODO(GYP)
- "//extensions:extensions_browsertests", # TODO(GYP)
- "//extensions:extensions_unittests", # TODO(GYP)
- "//mojo", # TODO(GYP)
- "//mojo/application/public/cpp", # TODO(GYP)
+ "//extensions:extensions_browsertests", # TODO(GYP) Needs ContentMain
- # TODO(GYP): Re-enable this as soon as we can link Blink binaries on mac.
- "//third_party/WebKit/Source/platform:heap_unittests",
- "//third_party/WebKit/Source/platform:platform_unittests",
- "//third_party/WebKit/Source/web:webkit_unit_tests",
+ # Mojo in GN contains some things which are never compiled in GYP on Mac,
+ # so compilation fails on Mac. They need porting.
+ "//mojo", # TODO(GYP)
]
}
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698