Add an external_startup_data config to the GN buildfile.

Add an external_startup_data config to the GN buildfile.

This change defines a common config for clients of v8 that
need to define V8_USE_EXTERNAL_STARTUP_DATA in order for
client code to be compiled correctly.

R=brettw@chromium.org, jochen@chromium.org
BUG=541791
LOG=n

Committed: https://crrev.com/5c1b11b5390adae297264fda8ddde02cb33298c1
Cr-Commit-Position: refs/heads/master@{#31427}

[Dirk Pranke, 2015-10-20 00:44:14]

See https://codereview.chromium.org/1413893003/ for the context for this (and
the usage).

[jochen (gone - plz use gerrit), 2015-10-20 08:10:25]

lgtm

[Dirk Pranke, 2015-10-20 21:20:30]

Description was changed from

==========
Add an external_startup_data config to the GN buildfile.

This change defines a common config for clients of v8 that
need to define V8_USE_EXTERNAL_STARTUP_DATA in order for
client code to be compiled correctly.

We define this config conditionally (only if
v8_use_external_startup_data is true) so that callers must
also import //build_overrides/v8.gni and conditionally
depend on the config as needed.

R=brettw@chromium.org, jochen@chromium.org
BUG=541791
==========

to

==========
Add an external_startup_data config to the GN buildfile.

This change defines a common config for clients of v8 that
need to define V8_USE_EXTERNAL_STARTUP_DATA in order for
client code to be compiled correctly.

R=brettw@chromium.org, jochen@chromium.org
BUG=541791
==========

[Dirk Pranke, 2015-10-20 21:21:00]

Brett, please take another look?

[brettw, 2015-10-20 23:05:39]

lgtm

[Dirk Pranke, 2015-10-20 23:38:27]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-10-20 23:38:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1415773003/#ps20001
(title: "make config exist unconditionally")

[commit-bot: I haz the power, 2015-10-20 23:38:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415773003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415773003/20001

[commit-bot: I haz the power, 2015-10-20 23:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 23:43:41]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6865)

[Dirk Pranke, 2015-10-20 23:49:47]

Description was changed from

==========
Add an external_startup_data config to the GN buildfile.

This change defines a common config for clients of v8 that
need to define V8_USE_EXTERNAL_STARTUP_DATA in order for
client code to be compiled correctly.

R=brettw@chromium.org, jochen@chromium.org
BUG=541791
==========

to

==========
Add an external_startup_data config to the GN buildfile.

This change defines a common config for clients of v8 that
need to define V8_USE_EXTERNAL_STARTUP_DATA in order for
client code to be compiled correctly.

R=brettw@chromium.org, jochen@chromium.org
BUG=541791
LOG=n
==========

[Dirk Pranke, 2015-10-20 23:50:04]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-10-20 23:50:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415773003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415773003/20001

[commit-bot: I haz the power, 2015-10-21 00:37:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-21 00:37:53]

Patchset 2 (id:??) landed as
https://crrev.com/5c1b11b5390adae297264fda8ddde02cb33298c1
Cr-Commit-Position: refs/heads/master@{#31427}