gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 1415763009: command_buffer: Make inactive bound fragment inputs reserve the location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1415763009: command_buffer: Make inactive bound fragment inputs reserve the location (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@binduniformlocation-reserve-location

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/GLES2/extensions/CHROMIUM/CHROMIUM_path_rendering.txt ('k') | gpu/command_buffer/service/program_manager.h » ('j') | gpu/command_buffer/service/program_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index cc1471b221e94778e1e0e1caf79c498605795a70..fb86506049f478059eb8543db9c63eee0dc655e5 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -15535,9 +15535,8 @@ error::Error GLES2DecoderImpl::HandleProgramPathFragmentInputGenCHROMIUM(

}

GLint location = static_cast<GLint>(c.location);

- if (location == -1) {

+ if (program->IsInactiveFragmentInputLocationByFakeLocation(location))

return error::kNoError;

- }

const Program::FragmentInputInfo* fragment_input_info =

program->GetFragmentInputInfoByFakeLocation(location);