Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1415763008: cc: Remove ThreadProxy dependency on LTHI::CurrentBeginFrameArgs (Closed)

Created:
5 years, 1 month ago by brianderson
Modified:
5 years, 1 month ago
CC:
chromium-reviews, rjkroege, cc-bugs_chromium.org, scheduler-bugs_chromium.org, Sami, alex clarke (OOO till 29th)
Base URL:
https://chromium.googlesource.com/chromium/src.git@CompositorTimingHistory2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove ThreadProxy dependency on LTHI::CurrentBeginFrameArgs ScheduledActionSendBeginMainFrame and RecordMainFrameTiming now use BeginFrameArgs provided directly from cc::Scheduler. BUG=469953, 346230 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/266dc3a09194417b1e2a91d5c82d184f19137ab5 Cr-Commit-Position: refs/heads/master@{#359227}

Patch Set 1 #

Patch Set 2 : use cc:: in mus #

Patch Set 3 : use correct upstream #

Patch Set 4 : really fix mus #

Patch Set 5 : 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -27 lines) Patch
M cc/scheduler/scheduler.h View 2 1 chunk +2 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 2 4 chunks +21 lines, -9 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 2 chunks +2 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 2 2 chunks +4 lines, -5 lines 0 comments Download
M components/mus/surfaces/surfaces_scheduler.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/surfaces/surfaces_scheduler.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (12 generated)
brianderson
ptal! This patch depends on: https://codereview.chromium.org/1432463002/ Unit tests pass for me locally.
5 years, 1 month ago (2015-11-06 01:33:52 UTC) #2
brianderson
+fsamuel for /mus
5 years, 1 month ago (2015-11-06 20:20:54 UTC) #4
Fady Samuel
mus lgtm
5 years, 1 month ago (2015-11-06 20:24:34 UTC) #5
mithro-old
On 2015/11/06 20:24:34, Fady Samuel wrote: > mus lgtm LGTM. I assume this passes the ...
5 years, 1 month ago (2015-11-07 04:05:37 UTC) #6
brianderson
On 2015/11/07 04:05:37, mithro wrote: > On 2015/11/06 20:24:34, Fady Samuel wrote: > > mus ...
5 years, 1 month ago (2015-11-11 07:10:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415763008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415763008/1
5 years, 1 month ago (2015-11-11 07:11:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/139070) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-11 07:20:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415763008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415763008/40001
5 years, 1 month ago (2015-11-11 16:27:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/156273)
5 years, 1 month ago (2015-11-11 16:39:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415763008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415763008/60001
5 years, 1 month ago (2015-11-11 20:54:06 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/117619)
5 years, 1 month ago (2015-11-11 21:05:53 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415763008/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415763008/80001
5 years, 1 month ago (2015-11-11 23:57:19 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-12 03:16:47 UTC) #25
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:03:43 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/266dc3a09194417b1e2a91d5c82d184f19137ab5
Cr-Commit-Position: refs/heads/master@{#359227}

Powered by Google App Engine
This is Rietveld 408576698