Call -browserWillBeDestroyed before releasing ToolbarController in unit tests.

Call -browserWillBeDestroyed before releasing ToolbarController in unit tests.

This addresses a use after free issue in LocationBarViewMac, caused
because the browser object is freed and released before the
ToolbarController in unit tests. This occurs despite an explicit
release of the ToolbarController in the unit test TearDown as the
NSViewController retains an additional reference that persists
the ToolbarController (and hence LocationBarViewMac) beyond the
browser object's lifetime.

BUG=535321
Committed: https://crrev.com/7f6f0f9765d4f05a8d714077f9a3c3eef31f2d55
Cr-Commit-Position: refs/heads/master@{#357641}

[dominickn, 2015-11-03 04:35:42]

Description was changed from

==========
Call -browserWillBeDestroyed before release in ToolbarController unit tests.

This addresses a use after free issue in LocationBarViewMac, caused
because the browser object is freed and released before the
ToolbarController in unit tests. This occurs despite an explict
release of the ToolbarController as the NSViewController retains
an additional reference to it that persists the object beyond the
browser object's lifetime.

BUG=535321
==========

to

==========
Call -browserWillBeDestroyed before release in ToolbarController unit tests.

This addresses a use after free issue in LocationBarViewMac, caused
because the browser object is freed and released before the
ToolbarController in unit tests. This occurs despite an explict
release of the ToolbarController as the NSViewController retains
an additional reference to it that persists the object beyond the
browser object's lifetime.

BUG=535321
==========

[dominickn, 2015-11-03 04:35:42]

dominickn@chromium.org changed reviewers:
+ avi@chromium.org

[dominickn, 2015-11-03 04:36:05]

dominickn@chromium.org changed reviewers:
- avi@chromium.org

[dominickn, 2015-11-03 04:37:19]

dominickn@chromium.org changed reviewers:
+ avi@chromium.org

[dominickn, 2015-11-03 04:37:19]

PTAL. This fixes the underlying use-after-free cause for the revet of a
scoped_ptr change in https://codereview.chromium.org/1356483002/. Thanks!

[dominickn, 2015-11-03 04:37:55]

Description was changed from

==========
Call -browserWillBeDestroyed before release in ToolbarController unit tests.

This addresses a use after free issue in LocationBarViewMac, caused
because the browser object is freed and released before the
ToolbarController in unit tests. This occurs despite an explict
release of the ToolbarController as the NSViewController retains
an additional reference to it that persists the object beyond the
browser object's lifetime.

BUG=535321
==========

to

==========
Call -browserWillBeDestroyed before releasing ToolbarController in unit tests.

This addresses a use after free issue in LocationBarViewMac, caused
because the browser object is freed and released before the
ToolbarController in unit tests. This occurs despite an explict
release of the ToolbarController as the NSViewController retains
an additional reference to it that persists the object beyond the
browser object's lifetime.

BUG=535321
==========

[dominickn, 2015-11-03 04:38:42]

Description was changed from

==========
Call -browserWillBeDestroyed before releasing ToolbarController in unit tests.

This addresses a use after free issue in LocationBarViewMac, caused
because the browser object is freed and released before the
ToolbarController in unit tests. This occurs despite an explict
release of the ToolbarController as the NSViewController retains
an additional reference to it that persists the object beyond the
browser object's lifetime.

BUG=535321
==========

to

==========
Call -browserWillBeDestroyed before releasing ToolbarController in unit tests.

This addresses a use after free issue in LocationBarViewMac, caused
because the browser object is freed and released before the
ToolbarController in unit tests. This occurs despite an explicit
release of the ToolbarController in the unit test TearDown as the
NSViewController retains an additional reference that persists
the ToolbarController (and hence LocationBarViewMac) beyond the
browser object's lifetime.

BUG=535321
==========

[Avi (use Gerrit), 2015-11-03 15:30:27]

lgtm

[dominickn, 2015-11-03 21:18:46]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2015-11-03 21:21:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415743011/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415743011/1

[commit-bot: I haz the power, 2015-11-03 21:47:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-03 21:48:46]

Patchset 1 (id:??) landed as
https://crrev.com/7f6f0f9765d4f05a8d714077f9a3c3eef31f2d55
Cr-Commit-Position: refs/heads/master@{#357641}