Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: net/quic/quic_connection.cc

Issue 1415743010: Removing quic_allow_oversized_packets_for_test by generating and writing packets without a QuicConn… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106389203
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 180e196dd6e5509c58ea69f4cb2ad25ab20fb7ab..b676fc2f4dd1f4345c13e43bb06ba2886da8f243 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1523,9 +1523,7 @@ bool QuicConnection::WritePacketInner(QueuedPacket* packet) {
}
}
- if (!FLAGS_quic_allow_oversized_packets_for_test) {
- DCHECK_LE(encrypted->length(), kMaxPacketSize);
- }
+ DCHECK_LE(encrypted->length(), kMaxPacketSize);
DCHECK_LE(encrypted->length(), packet_generator_.GetMaxPacketLength());
DVLOG(1) << ENDPOINT << "Sending packet " << packet_number << " : "
<< (packet->serialized_packet.is_fec_packet
@@ -2251,10 +2249,6 @@ void QuicConnection::SetMtuDiscoveryTarget(QuicByteCount target) {
QuicByteCount QuicConnection::LimitMaxPacketSize(
QuicByteCount suggested_max_packet_size) {
- if (FLAGS_quic_allow_oversized_packets_for_test) {
- return suggested_max_packet_size;
- }
-
if (peer_address_.address().empty()) {
LOG(DFATAL) << "Attempted to use a connection without a valid peer address";
return suggested_max_packet_size;
« no previous file with comments | « no previous file | net/quic/quic_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698