Prevent the Online Reauth window from opening twice.

Prevent the Online Reauth window from opening twice.

BUG=534726
TEST=
1. Add a supervised user to Chrome
2. From a regular profile, click on the avatar button and select
   "Exit and Childlock"
3. In the User Manager, click on the yellow triangle next to the
   locked profile's name
4. The Online Reauth window should open once, not open-close-reopen

Committed: https://crrev.com/e020927c5d71942748f67c25c347d1355dd11135
Cr-Commit-Position: refs/heads/master@{#355139}

[anthonyvd, 2015-10-19 19:43:08]

anthonyvd@chromium.org changed reviewers:
+ groby@chromium.org

[anthonyvd, 2015-10-19 19:43:08]

Hi groby@,

Can you please take a look at this small CL that fixes a bug where the reauth
window would open, close, then reopen when the user clicked on the yellow "auth
error" triangle in the user manager.

Clicking anywhere else in the pod doesn't trigger this issue, so it seems like
clicking the icon ends up propagating the click event twice or something of the
sort. I'll be looking into why that happens when I get a chance but this seems
like a good change anyways that happens to fix the bug.

Thanks a lot for your time :)

[groby-ooo-7-16, 2015-10-19 20:09:31]

LGTM w/ nits

https://codereview.chromium.org/1415743002/diff/1/chrome/browser/ui/cocoa/pro...
File chrome/browser/ui/cocoa/profiles/user_manager_mac.mm (right):

https://codereview.chromium.org/1415743002/diff/1/chrome/browser/ui/cocoa/pro...
chrome/browser/ui/cocoa/profiles/user_manager_mac.mm:368: if
(!reauth_window_controller_.get()) {
Nit: no .get() needed

https://codereview.chromium.org/1415743002/diff/1/chrome/browser/ui/cocoa/pro...
chrome/browser/ui/cocoa/profiles/user_manager_mac.mm:379:
reauth_window_controller_.reset();
Q: Doesn't reset() imply -close?

[anthonyvd, 2015-10-20 19:40:49]

https://codereview.chromium.org/1415743002/diff/1/chrome/browser/ui/cocoa/pro...
File chrome/browser/ui/cocoa/profiles/user_manager_mac.mm (right):

https://codereview.chromium.org/1415743002/diff/1/chrome/browser/ui/cocoa/pro...
chrome/browser/ui/cocoa/profiles/user_manager_mac.mm:368: if
(!reauth_window_controller_.get()) {
On 2015/10/19 20:09:31, groby wrote:
> Nit: no .get() needed

Done.

https://codereview.chromium.org/1415743002/diff/1/chrome/browser/ui/cocoa/pro...
chrome/browser/ui/cocoa/profiles/user_manager_mac.mm:379:
reauth_window_controller_.reset();
On 2015/10/19 20:09:31, groby wrote:
> Q: Doesn't reset() imply -close?
> 

It does, thanks for noticing!

[anthonyvd, 2015-10-20 19:40:53]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2015-10-20 19:40:53]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/1415743002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-10-20 19:41:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415743002/20001

[commit-bot: I haz the power, 2015-10-20 20:09:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-20 20:10:50]

Patchset 2 (id:??) landed as
https://crrev.com/e020927c5d71942748f67c25c347d1355dd11135
Cr-Commit-Position: refs/heads/master@{#355139}

[anthonyvd, 2015-10-22 14:05:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1413663008/ by anthonyvd@chromium.org.

The reason for reverting is: Reverting this as it caused Issue 545819 which
would prevent people from unlocking profiles on canary.