Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1788)

Unified Diff: ui/gl/gl_image_shared_memory_unittest.cc

Issue 1415723006: ui: Add RGBX_8888 buffer format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gles but no conversion needed case Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_image_shared_memory.cc ('k') | ui/gl/gl_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_image_shared_memory_unittest.cc
diff --git a/ui/gl/gl_image_shared_memory_unittest.cc b/ui/gl/gl_image_shared_memory_unittest.cc
index 9c280f96b62a6281877d03bd18009f30cb8f83dc..98eb20edd5ddf4fc220d8b0e0cfe106ddaf73e27 100644
--- a/ui/gl/gl_image_shared_memory_unittest.cc
+++ b/ui/gl/gl_image_shared_memory_unittest.cc
@@ -10,11 +10,10 @@
namespace gfx {
namespace {
+template <BufferFormat format>
class GLImageSharedMemoryTestDelegate {
public:
scoped_refptr<GLImage> CreateSolidColorImage(const Size& size,
- unsigned internalformat,
- BufferFormat format,
const uint8_t color[4]) const {
DCHECK_EQ(NumberOfPlanesForBufferFormat(format), 1u);
base::SharedMemory shared_memory;
@@ -25,8 +24,8 @@ class GLImageSharedMemoryTestDelegate {
size.width(), size.height(),
static_cast<int>(RowSizeForBufferFormat(size.width(), format, 0)),
format, color, reinterpret_cast<uint8_t*>(shared_memory.memory()));
- scoped_refptr<GLImageSharedMemory> image(
- new GLImageSharedMemory(size, internalformat));
+ scoped_refptr<GLImageSharedMemory> image(new GLImageSharedMemory(
+ size, GLImageMemory::GetInternalFormatForTesting(format)));
rv = image->Initialize(
base::SharedMemory::DuplicateHandle(shared_memory.handle()),
GenericSharedMemoryId(0), format);
@@ -35,13 +34,19 @@ class GLImageSharedMemoryTestDelegate {
}
};
+using GLImageTestTypes =
+ testing::Types<GLImageSharedMemoryTestDelegate<BufferFormat::RGBX_8888>,
+ GLImageSharedMemoryTestDelegate<BufferFormat::RGBA_8888>,
+ GLImageSharedMemoryTestDelegate<BufferFormat::BGRX_8888>,
+ GLImageSharedMemoryTestDelegate<BufferFormat::BGRA_8888>>;
+
INSTANTIATE_TYPED_TEST_CASE_P(GLImageSharedMemory,
GLImageTest,
- GLImageSharedMemoryTestDelegate);
+ GLImageTestTypes);
INSTANTIATE_TYPED_TEST_CASE_P(GLImageSharedMemory,
GLImageCopyTest,
- GLImageSharedMemoryTestDelegate);
+ GLImageTestTypes);
} // namespace
} // namespace gfx
« no previous file with comments | « ui/gl/gl_image_shared_memory.cc ('k') | ui/gl/gl_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698