gpu/command_buffer/service/image_factory.cc - Issue 1415723006: ui: Add RGBX_8888 buffer format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/image_factory.cc

Issue 1415723006: ui: Add RGBX_8888 buffer format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gles but no conversion needed case Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/gpu_memory_buffer_factory_io_surface.cc ('k') | gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/image_factory.cc

diff --git a/gpu/command_buffer/service/image_factory.cc b/gpu/command_buffer/service/image_factory.cc

index cfc543bb9c19cf3a5f255b57bb2071002181a0a9..2a1257eb49a86b7d562447b0b5edc9ec7741e6e4 100644

--- a/gpu/command_buffer/service/image_factory.cc

+++ b/gpu/command_buffer/service/image_factory.cc

@@ -75,6 +75,7 @@ bool ImageFactory::IsImageFormatCompatibleWithGpuMemoryBufferFormat(

case gfx::BufferFormat::ETC1:

case gfx::BufferFormat::R_8:

case gfx::BufferFormat::RGBA_8888:

+ case gfx::BufferFormat::RGBX_8888:

case gfx::BufferFormat::YUV_420:

case gfx::BufferFormat::YUV_420_BIPLANAR:

case gfx::BufferFormat::UYVY_422:

@@ -96,6 +97,7 @@ bool ImageFactory::IsGpuMemoryBufferFormatSupported(

case gfx::BufferFormat::ATCIA:

return capabilities.texture_format_atc;

case gfx::BufferFormat::BGRA_8888:

+ case gfx::BufferFormat::BGRX_8888:

return capabilities.texture_format_bgra8888;

case gfx::BufferFormat::DXT1:

return capabilities.texture_format_dxt1;

@@ -109,7 +111,7 @@ bool ImageFactory::IsGpuMemoryBufferFormatSupported(

return capabilities.image_ycbcr_422;

case gfx::BufferFormat::RGBA_4444:

case gfx::BufferFormat::RGBA_8888:

- case gfx::BufferFormat::BGRX_8888:

+ case gfx::BufferFormat::RGBX_8888:

case gfx::BufferFormat::YUV_420:

return true;

case gfx::BufferFormat::YUV_420_BIPLANAR:

@@ -136,6 +138,7 @@ bool ImageFactory::IsImageSizeValidForGpuMemoryBufferFormat(

case gfx::BufferFormat::R_8:

case gfx::BufferFormat::RGBA_4444:

case gfx::BufferFormat::RGBA_8888:

+ case gfx::BufferFormat::RGBX_8888:

case gfx::BufferFormat::BGRA_8888:

case gfx::BufferFormat::BGRX_8888:

return true;