ui: Add RGBX_8888 buffer format.

ui/gl/test/gl_image_test_template.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines tests that implementations of GLImage should pass in order
 // to be conformant.
 
 #ifndef UI_GL_TEST_GL_IMAGE_TEST_TEMPLATE_H_
 #define UI_GL_TEST_GL_IMAGE_TEST_TEMPLATE_H_
 
@@ skipping 40 matching lines @@
 
 TYPED_TEST_CASE_P(GLImageTest);
 
 TYPED_TEST_P(GLImageTest, CreateAndDestroy) {
   const Size small_image_size(4, 4);
   const Size large_image_size(512, 512);
   const uint8_t image_color[] = {0, 0xff, 0, 0xff};
 
   // Create a small solid color green image of preferred format. This must
   // succeed in order for a GLImage to be conformant.
-  scoped_refptr<GLImage> small_image = this->delegate_.CreateSolidColorImage(
-      small_image_size, GLImageTestSupport::GetPreferredInternalFormat(),
-      GLImageTestSupport::GetPreferredBufferFormat(), image_color);
+  scoped_refptr<GLImage> small_image =
+      this->delegate_.CreateSolidColorImage(small_image_size, image_color);
   ASSERT_TRUE(small_image);
 
   // Create a large solid color green image of preferred format. This must
   // succeed in order for a GLImage to be conformant.
-  scoped_refptr<GLImage> large_image = this->delegate_.CreateSolidColorImage(
-      large_image_size, GLImageTestSupport::GetPreferredInternalFormat(),
-      GLImageTestSupport::GetPreferredBufferFormat(), image_color);
+  scoped_refptr<GLImage> large_image =
+      this->delegate_.CreateSolidColorImage(large_image_size, image_color);
   ASSERT_TRUE(large_image);
 
   // Verify that image size is correct.
   EXPECT_EQ(small_image->GetSize().ToString(), small_image_size.ToString());
   EXPECT_EQ(large_image->GetSize().ToString(), large_image_size.ToString());
 
-  // Verify that internal format is correct.
-  EXPECT_EQ(small_image->GetInternalFormat(),
-            GLImageTestSupport::GetPreferredInternalFormat());
-  EXPECT_EQ(large_image->GetInternalFormat(),
-            GLImageTestSupport::GetPreferredInternalFormat());
-
   // Verify that destruction of images work correctly both when we have a
   // context and when we don't.
   small_image->Destroy(true /* have_context */);
   large_image->Destroy(false /* have_context */);
 }
 
 // The GLImageTest test case verifies the behaviour that is expected from a
 // GLImage in order to be conformant.
 REGISTER_TYPED_TEST_CASE_P(GLImageTest, CreateAndDestroy);
 
 template <typename GLImageTestDelegate>
 class GLImageCopyTest : public GLImageTest<GLImageTestDelegate> {};
 
 TYPED_TEST_CASE_P(GLImageCopyTest);
 
 TYPED_TEST_P(GLImageCopyTest, CopyTexImage) {
   const Size image_size(256, 256);
-  const uint8_t image_color[] = {0, 0xff, 0, 0xff};
+  const uint8_t image_color[] = {0xff, 0xff, 0, 0xff};
   const uint8_t texture_color[] = {0, 0, 0xff, 0xff};
 
   GLuint framebuffer =
       GLTestHelper::SetupFramebuffer(image_size.width(), image_size.height());
   ASSERT_TRUE(framebuffer);
   glBindFramebufferEXT(GL_FRAMEBUFFER, framebuffer);
   glViewport(0, 0, image_size.width(), image_size.height());
 
   // Create a solid color green image of preferred format. This must succeed
   // in order for a GLImage to be conformant.
-  scoped_refptr<GLImage> image = this->delegate_.CreateSolidColorImage(
-      image_size, GLImageTestSupport::GetPreferredInternalFormat(),
-      GLImageTestSupport::GetPreferredBufferFormat(), image_color);
+  scoped_refptr<GLImage> image =
+      this->delegate_.CreateSolidColorImage(image_size, image_color);
   ASSERT_TRUE(image);
 
   // Create a solid color blue texture of the same size as |image|.
   GLuint texture = GLTestHelper::CreateTexture(GL_TEXTURE_2D);
   scoped_ptr<uint8_t[]> pixels(new uint8_t[BufferSizeForBufferFormat(
-      image_size, GLImageTestSupport::GetPreferredBufferFormat())]);
+      image_size, BufferFormat::RGBA_8888)]);
   GLImageTestSupport::SetBufferDataToColor(
       image_size.width(), image_size.height(),
-      static_cast<int>(RowSizeForBufferFormat(
-          image_size.width(), GLImageTestSupport::GetPreferredBufferFormat(),
-          0)),
-      GLImageTestSupport::GetPreferredBufferFormat(), texture_color,
-      pixels.get());
+      static_cast<int>(RowSizeForBufferFormat(image_size.width(),
+                                              BufferFormat::RGBA_8888, 0)),
+      BufferFormat::RGBA_8888, texture_color, pixels.get());
   // Note: This test assume that |image| can be used with GL_TEXTURE_2D but
   // that might not be the case for some GLImage implementations.
   glBindTexture(GL_TEXTURE_2D, texture);
-  glTexImage2D(GL_TEXTURE_2D, 0,
-               GLImageTestSupport::GetPreferredInternalFormat(),
-               image_size.width(), image_size.height(), 0,
-               GLImageTestSupport::GetPreferredInternalFormat(),
-               GL_UNSIGNED_BYTE, pixels.get());
+  glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, image_size.width(),
+               image_size.height(), 0, GL_RGBA, GL_UNSIGNED_BYTE, pixels.get());
 
   // Copy |image| to |texture|.
   bool rv = image->CopyTexImage(GL_TEXTURE_2D);
   EXPECT_TRUE(rv);
 
   // clang-format off
   const char kVertexShader[] = STRINGIZE(
     attribute vec2 a_position;
     attribute vec2 a_texCoord;
     varying vec2 v_texCoord;
@@ skipping 70 matching lines @@
   image->Destroy(true);
 }
 
 // The GLImageCopyTest test case verifies that the GLImage implementation
 // handles CopyTexImage correctly.
 REGISTER_TYPED_TEST_CASE_P(GLImageCopyTest, CopyTexImage);
 
 }  // namespace gfx
 
 #endif  // UI_GL_TEST_GL_IMAGE_TEST_TEMPLATE_H_