src/runtime/runtime-classes.cc - Issue 1415723005: Ensure we never inline class constructors in Crankshaft, as it currently is entirely unsupported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-classes.cc

Issue 1415723005: Ensure we never inline class constructors in Crankshaft, as it currently is entirely unsupported. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-classes.cc

diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc

index 8eee6b808ec3c5df6331d15e11297047f7cac0aa..b0cee1a44a98afd401c36d293b428a4c0bc280b9 100644

--- a/src/runtime/runtime-classes.cc

+++ b/src/runtime/runtime-classes.cc

@@ -133,6 +133,7 @@ static MaybeHandle<Object> DefineClass(Isolate* isolate, Handle<Object> name,

}

Map::SetPrototype(map, prototype_parent);

map->SetConstructor(*constructor);

+ map->set_is_prototype_map(true);

adamk 2015/10/22 12:01:32 Is this related to your change?

Toon Verwaest 2015/10/22 13:50:56 No, I'll remove for now.

Handle<JSObject> prototype = isolate->factory()->NewJSObjectFromMap(map);

Handle<String> name_string = name->IsString()

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | test/mjsunit/regress/regress-inline-class-constructor.js » ('j') | no next file with comments »