Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1415723005: Ensure we never inline class constructors in Crankshaft, as it currently is entirely unsupported. (Closed)

Created:
5 years, 2 months ago by Toon Verwaest
Modified:
5 years, 2 months ago
Reviewers:
Camillo Bruni, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure we never inline class constructors in Crankshaft, as it currently is entirely unsupported. BUG=v8:3330 LOG=n Committed: https://crrev.com/f464f12a8b97fc0635651b88b0c37bcd74fd1af8 Cr-Commit-Position: refs/heads/master@{#31480}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-inline-class-constructor.js View 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Toon Verwaest
ptal
5 years, 2 months ago (2015-10-22 11:50:59 UTC) #3
adamk
lgtm % question about runtime-classes change https://codereview.chromium.org/1415723005/diff/1/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/1415723005/diff/1/src/runtime/runtime-classes.cc#newcode136 src/runtime/runtime-classes.cc:136: map->set_is_prototype_map(true); Is this ...
5 years, 2 months ago (2015-10-22 12:01:32 UTC) #4
Toon Verwaest
https://codereview.chromium.org/1415723005/diff/1/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/1415723005/diff/1/src/runtime/runtime-classes.cc#newcode136 src/runtime/runtime-classes.cc:136: map->set_is_prototype_map(true); On 2015/10/22 12:01:32, adamk wrote: > Is this ...
5 years, 2 months ago (2015-10-22 13:50:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415723005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415723005/20001
5 years, 2 months ago (2015-10-22 13:54:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 14:38:40 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 14:39:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f464f12a8b97fc0635651b88b0c37bcd74fd1af8
Cr-Commit-Position: refs/heads/master@{#31480}

Powered by Google App Engine
This is Rietveld 408576698