Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1415683011: [heap] Fix corner case in optimized code map processing. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix corner case in optimized code map processing. This fixes a corner case where optimized code could still be reachable through the optimized code map, even though unoptimized code for any inlined function might have long been flushed. R=ulan@chromium.org TEST=cctest/test-heap/Regress513496 BUG=chromium:513496 LOG=n Committed: https://crrev.com/aac8ee84affbff5b0516e75340acf5fc417bee80 Cr-Commit-Position: refs/heads/master@{#31857}

Patch Set 1 #

Patch Set 2 : Fix for half initialized code. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -10 lines) Patch
M src/heap/objects-visiting-inl.h View 1 2 3 chunks +16 lines, -10 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-05 15:47:18 UTC) #1
ulan
lgtm!
5 years, 1 month ago (2015-11-05 15:52:14 UTC) #2
Hannes Payer (out of office)
lgtm!
5 years, 1 month ago (2015-11-05 19:40:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415683011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415683011/40001
5 years, 1 month ago (2015-11-06 14:27:44 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-06 14:28:56 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 14:29:34 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aac8ee84affbff5b0516e75340acf5fc417bee80
Cr-Commit-Position: refs/heads/master@{#31857}

Powered by Google App Engine
This is Rietveld 408576698