Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1415683010: cleanup/Remove deprecated notification from extension_functional_browsertest.cc (Closed)

Created:
5 years, 1 month ago by sooho1000
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cleanup/Remove deprecated notification from extension_functional_browsertest.cc BUG=411568 Committed: https://crrev.com/5109c32e94dc20a1ab6f03c94d1cfbc22f114cd8 Cr-Commit-Position: refs/heads/master@{#358559}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_functional_browsertest.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sooho1000
Please review this patch. Thanks.
5 years, 1 month ago (2015-11-05 04:49:27 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 1 month ago (2015-11-06 16:44:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415683010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415683010/1
5 years, 1 month ago (2015-11-07 12:32:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/116589)
5 years, 1 month ago (2015-11-07 12:39:37 UTC) #8
limasdf
sooho@, you should add yourself to /src/AUTHORS.
5 years, 1 month ago (2015-11-09 00:08:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415683010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415683010/20001
5 years, 1 month ago (2015-11-09 00:09:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-09 00:38:28 UTC) #14
commit-bot: I haz the power
Failed to apply the patch.
5 years, 1 month ago (2015-11-09 00:38:47 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 00:39:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5109c32e94dc20a1ab6f03c94d1cfbc22f114cd8
Cr-Commit-Position: refs/heads/master@{#358559}

Powered by Google App Engine
This is Rietveld 408576698