Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1415663002: Revert "[api] expose Array Iterators to API" (Closed)

Created:
5 years, 2 months ago by caitp (gmail)
Modified:
5 years, 2 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[api] expose Array Iterators to API" This reverts commit 24aca8709000f1d05341aaa7f131369896f72b63. The API makes these values appear to be per-isolate, when in fact they are per-context. Installing the results of these on Template objects instantiated in multiple contexts can result in security violations and contexts being retained indefinitely. An alternative mechanism for using these in a sensible way is provided by https://crrev.com/1409593002 BUG= LOG=N R=jochen@chromium.org, adamk@chromium.org Committed: https://crrev.com/d09a925b9ae8724873268add70570506cb9ca469 Cr-Commit-Position: refs/heads/master@{#31417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -57 lines) Patch
M include/v8.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/js/array-iterator.js View 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
caitp (gmail)
PTAL
5 years, 2 months ago (2015-10-19 15:46:44 UTC) #1
caitp (gmail)
PTAL
5 years, 2 months ago (2015-10-19 15:46:45 UTC) #2
caitp (gmail)
On 2015/10/19 15:46:45, caitp wrote: > PTAL Sorry for the spam :(
5 years, 2 months ago (2015-10-19 15:47:13 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-20 09:34:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415663002/1
5 years, 2 months ago (2015-10-20 14:24:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 15:25:31 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 15:25:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d09a925b9ae8724873268add70570506cb9ca469
Cr-Commit-Position: refs/heads/master@{#31417}

Powered by Google App Engine
This is Rietveld 408576698