Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 141563014: Make dmprof handle long runs better (Closed)

Created:
6 years, 10 months ago by Jens Widell
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make dmprof handle long runs better Read the dump files one by one as they are processed instead of reading them all into memory at the start of the program, to reduce peak memory consumption. This makes it possible to process larger data sets. Also restructure a few sub-command implementations to avoid iterating over the list of dumps more than once and to avoid accessing any given dump (typically the first) more than once. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248458

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add notes to DumpList class documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -22 lines) Patch
M tools/deep_memory_profiler/lib/dump.py View 1 1 chunk +14 lines, -12 lines 0 comments Download
M tools/deep_memory_profiler/subcommands/cat.py View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/deep_memory_profiler/subcommands/policies.py View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jens Widell
Please take a look. This aims to improve the usability of the dmprof program on ...
6 years, 10 months ago (2014-01-31 14:50:21 UTC) #1
Dai Mikurube (NOT FULLTIME)
lgtm with a nit. Thanks for working on it! https://codereview.chromium.org/141563014/diff/1/tools/deep_memory_profiler/lib/dump.py File tools/deep_memory_profiler/lib/dump.py (right): https://codereview.chromium.org/141563014/diff/1/tools/deep_memory_profiler/lib/dump.py#newcode410 tools/deep_memory_profiler/lib/dump.py:410: ...
6 years, 10 months ago (2014-02-03 07:00:24 UTC) #2
Jens Widell
https://codereview.chromium.org/141563014/diff/1/tools/deep_memory_profiler/lib/dump.py File tools/deep_memory_profiler/lib/dump.py (right): https://codereview.chromium.org/141563014/diff/1/tools/deep_memory_profiler/lib/dump.py#newcode410 tools/deep_memory_profiler/lib/dump.py:410: """Represents a sequence of heap profile dumps.""" On 2014/02/03 ...
6 years, 10 months ago (2014-02-03 07:29:57 UTC) #3
Dai Mikurube (NOT FULLTIME)
Still lgtm. Thanks!
6 years, 10 months ago (2014-02-03 07:31:06 UTC) #4
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 10 months ago (2014-02-03 07:33:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/141563014/60001
6 years, 10 months ago (2014-02-03 07:33:36 UTC) #6
Jens Widell
On 2014/02/03 07:31:06, Dai Mikurube wrote: > Still lgtm. Thanks! Thanks for reviewing!
6 years, 10 months ago (2014-02-03 07:33:41 UTC) #7
commit-bot: I haz the power
Change committed as 248458
6 years, 10 months ago (2014-02-03 09:14:15 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 09:14:15 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 09:14:17 UTC) #10
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698