Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 14156006: Simplify OSAllocator. (Closed)

Created:
7 years, 8 months ago by lgombos
Modified:
7 years, 8 months ago
CC:
blink-reviews, loislo+blink_chromium.org, jeez, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Simplify OSAllocator. Follow-up cleanup as discussed in https://chromiumcodereview.appspot.com/13901012/#msg2. Keep only the simple version of OSAllocator::decommitAndRelease(). Also remove PageAllocationAligned.cpp, it is no longer needed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -180 lines) Patch
M Source/wtf/OSAllocator.h View 2 chunks +1 line, -23 lines 0 comments Download
D Source/wtf/PageAllocationAligned.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/wtf/PageAllocationAligned.cpp View 1 chunk +0 lines, -85 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
Cleanup. Possibly more of the allocator code could be removed after changing regexp implementation in ...
7 years, 8 months ago (2013-04-21 04:02:51 UTC) #1
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-21 06:59:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14156006/1
7 years, 8 months ago (2013-04-21 06:59:19 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-21 07:12:36 UTC) #4
abarth-chromium
I think the linux_layout_rel bot is broken for some reason. The error it's reporting doesn't ...
7 years, 8 months ago (2013-04-21 07:15:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14156006/1
7 years, 8 months ago (2013-04-21 11:35:38 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-21 11:49:17 UTC) #7
Message was sent while issue was closed.
Change committed as 148790

Powered by Google App Engine
This is Rietveld 408576698