Support multiple storage partitions in chrome://indexeddb-internals/

Support multiple storage partitions in chrome://indexeddb-internals/

This allows us to discover indexeddb's that are in apps and extensions.
Each StoragePartition is calling back through to the JavaScript separately,
and each section will get rendered with its own header.

BUG=174188
TBR=joi@chromium.org,estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194674

[alecflett, 2013-04-12 01:08:38]

This is stacked on top of https://codereview.chromium.org/14118002/

jsbell / michaeln - r?

CC'ed ajwong just to make sure I got this right. This is just an internal
chrome:// url, so we're identifying each partition by its path.

[jsbell, 2013-04-12 21:25:59]

lgtm with one nit and a caution

(and a small rant about the verbosity of ad-hoc structures in C++)

https://codereview.chromium.org/14156003/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_internals_ui.cc (right):

https://codereview.chromium.org/14156003/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_internals_ui.cc:88:
DCHECK_EQ(contexts->size(), context_paths->size());
As discussed offline, an alternative would be to make it a
scoped_ptr<std::vector<std::pair<S,T> > > instead, but that's probably less
readable than what you have here

https://codereview.chromium.org/14156003/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_internals_ui.cc:92: for
(ContextList::const_iterator iter = contexts->begin();
... although it would make this dual-iteration slightly clearer. Ah well,
probably still not worth it.

https://codereview.chromium.org/14156003/diff/1/content/browser/resources/ind...
File content/browser/resources/indexed_db/indexeddb_internals.js (right):

https://codereview.chromium.org/14156003/diff/1/content/browser/resources/ind...
content/browser/resources/indexed_db/indexeddb_internals.js:13:
console.log('Origins: ', origins, path);
Might want to remove this now.

https://codereview.chromium.org/14156003/diff/1/content/public/browser/indexe...
File content/public/browser/indexed_db_info.h (right):

https://codereview.chromium.org/14156003/diff/1/content/public/browser/indexe...
content/public/browser/indexed_db_info.h:24: base::FilePath path;
Nit: path_ (and what about the others? or am I missing some subtlety with the
style guide?)

[michaeln, 2013-04-12 23:00:31]

lgtm2

https://codereview.chromium.org/14156003/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_internals_ui.cc (right):

https://codereview.chromium.org/14156003/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_internals_ui.cc:93: iter !=
contexts->end(); ++iter) {
nit: would dbl-iter be more clear with ++iter, ++path_iter being in the loop
construct?

https://codereview.chromium.org/14156003/diff/1/content/public/browser/indexe...
File content/public/browser/indexed_db_info.h (right):

https://codereview.chromium.org/14156003/diff/1/content/public/browser/indexe...
content/public/browser/indexed_db_info.h:24: base::FilePath path;
maybe just claim this is a struct instead of a class

[alecflett, 2013-04-17 21:08:33]

Committed patchset #7 manually as r194674 (presubmit successful).