Count usage of <meter> with various -webkit-appearance values.

Count usage of <meter> with various -webkit-appearance values.

BUG=51182
TBR=isherman@chromium.org

Committed: https://crrev.com/21d1b82c5178fe75cbcb610ee20675b2604f9b7f
Cr-Commit-Position: refs/heads/master@{#358294}

[tkent, 2015-11-06 05:58:09]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2015-11-06 05:58:09]

kochi@, would you review this please?

[kochi, 2015-11-06 06:14:26]

Could you also run

python tools/metrics/histograms/update_use_counter_feature_enum.py

to include histogram.xml change in one CL?

https://codereview.chromium.org/1415573015/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMeterElement.cpp (right):

https://codereview.chromium.org/1415573015/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMeterElement.cpp:79: default:
Shall we count this other appearances to get the total usage (as a denominator
for each)?

[tkent, 2015-11-06 08:31:36]

> python tools/metrics/histograms/update_use_counter_feature_enum.py

Done.

https://codereview.chromium.org/1415573015/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMeterElement.cpp (right):

https://codereview.chromium.org/1415573015/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMeterElement.cpp:79: default:
On 2015/11/06 at 06:14:26, Takayoshi Kochi wrote:
> Shall we count this other appearances to get the total usage (as a denominator
> for each)?

UseCounter::MeterElement would be the denominator.

[kochi, 2015-11-06 08:32:58]

lgtm

On 2015/11/06 08:31:36, tkent wrote:
> > python tools/metrics/histograms/update_use_counter_feature_enum.py
> 
> Done.
> 
>
https://codereview.chromium.org/1415573015/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/HTMLMeterElement.cpp (right):
> 
>
https://codereview.chromium.org/1415573015/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/HTMLMeterElement.cpp:79: default:
> On 2015/11/06 at 06:14:26, Takayoshi Kochi wrote:
> > Shall we count this other appearances to get the total usage (as a
denominator
> > for each)?
> 
> UseCounter::MeterElement would be the denominator.

sgtm

[tkent, 2015-11-06 09:17:44]

Description was changed from

==========
Count usage of <meter> with various -webkit-appearance values.

BUG=51182
==========

to

==========
Count usage of <meter> with various -webkit-appearance values.

BUG=51182
TBR=isherman@chromium.org
==========

[tkent, 2015-11-06 09:17:44]

tkent@chromium.org changed reviewers:
+ isherman@chromium.org

[tkent, 2015-11-06 09:18:56]

Add TBR=isherman@.  I'd like to land this now because UseCounter.h is fragile.

[tkent, 2015-11-06 09:19:23]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-11-06 09:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415573015/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415573015/20001

[commit-bot: I haz the power, 2015-11-06 10:04:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-06 10:05:04]

Patchset 2 (id:??) landed as
https://crrev.com/21d1b82c5178fe75cbcb610ee20675b2604f9b7f
Cr-Commit-Position: refs/heads/master@{#358294}

[Ilya Sherman, 2015-11-06 21:57:25]

lgtm