Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1415573008: Clean out TestExpectations for SVG in <object> tests (Closed)

Created:
5 years, 1 month ago by davve
Modified:
5 years, 1 month ago
Reviewers:
fs
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean out TestExpectations for SVG in <object> tests The timeouts and fails should be addressed now by splitting tests and slightly fuzzier matching. BUG=392640 Committed: https://crrev.com/1c779e7fbf11eabbf8bcfb336381c8024c9e4ee4 Cr-Commit-Position: refs/heads/master@{#357642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415573008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415573008/1
5 years, 1 month ago (2015-11-03 10:30:52 UTC) #2
davve
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Fas-object%2Fsizing%2Fsvg-in-object-placeholder- is looking quite green and stable now.
5 years, 1 month ago (2015-11-03 10:34:35 UTC) #4
fs
lgtm
5 years, 1 month ago (2015-11-03 11:36:34 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 18:12:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415573008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415573008/1
5 years, 1 month ago (2015-11-03 21:43:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 21:49:22 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 21:50:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c779e7fbf11eabbf8bcfb336381c8024c9e4ee4
Cr-Commit-Position: refs/heads/master@{#357642}

Powered by Google App Engine
This is Rietveld 408576698