Issue 1415573006: Merge to XFA: Add standard "Must be after no_chromium_code" comment in GN files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415573006: Merge to XFA: Add standard "Must be after no_chromium_code" comment in GN files. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add standard "Must be after no_chromium_code" comment in GN files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1411563004 . (cherry picked from commit 4793f674f29be8bf06a60672032e2e2df5164c8c) Committed: https://pdfium.googlesource.com/pdfium/+/4f9ccbffdb3165bd8cc4587548081bd551c7980e

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	BUILD.gn	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	third_party/BUILD.gn	View		3 chunks	+22 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

5 years, 1 month ago (2015-10-30 20:05:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4f9ccbffdb3165bd8cc4587548081bd551c7980e (presubmit successful).