Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: snapshot/win/module_snapshot_win.h

Issue 1415543003: win: Plumb module PDB name through snapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: mac Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: snapshot/win/module_snapshot_win.h
diff --git a/snapshot/win/module_snapshot_win.h b/snapshot/win/module_snapshot_win.h
index 7cdcc5668eb632ef470d513eac2864b27376e008..853baca4400a14bbf9bbbf5f5116810c16c3d1d5 100644
--- a/snapshot/win/module_snapshot_win.h
+++ b/snapshot/win/module_snapshot_win.h
@@ -81,6 +81,7 @@ class ModuleSnapshotWin final : public ModuleSnapshot {
uint16_t* version_3) const override;
ModuleType GetModuleType() const override;
void UUIDAndAge(crashpad::UUID* uuid, uint32_t* age) const override;
+ std::string DebugFileName() const override;
std::vector<std::string> AnnotationsVector() const override;
std::map<std::string, std::string> AnnotationsSimpleMap() const override;
@@ -89,6 +90,9 @@ class ModuleSnapshotWin final : public ModuleSnapshot {
void GetCrashpadOptionsInternal(CrashpadInfoClientOptions* options);
std::wstring name_;
+ std::string pdb_name_;
+ UUID uuid_;
+ uint32_t age_;
time_t timestamp_;
scoped_ptr<PEImageReader> pe_image_reader_;
Mark Mentovai 2015/10/29 13:11:10 Best would be name, pdb_name, uuid, pe_image_reade
scottmg 2015/10/29 17:47:00 Done.
ProcessReaderWin* process_reader_; // weak

Powered by Google App Engine
This is Rietveld 408576698