win: Plumb module PDB name through snapshot

minidump/minidump_module_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 596 matching lines @@
                                          nullptr,
                                          0,
                                          false));
   }
 }
 
 void InitializeTestModuleSnapshotFromMinidumpModule(
     TestModuleSnapshot* module_snapshot,
     const MINIDUMP_MODULE& minidump_module,
     const std::string& name,
+    const std::string& pdb_name,
     const crashpad::UUID& uuid,
     uint32_t age) {
   module_snapshot->SetName(name);
 
   module_snapshot->SetAddressAndSize(minidump_module.BaseOfImage,
                                      minidump_module.SizeOfImage);
   module_snapshot->SetTimestamp(minidump_module.TimeDateStamp);
   module_snapshot->SetFileVersion(
       minidump_module.VersionInfo.dwFileVersionMS >> 16,
       minidump_module.VersionInfo.dwFileVersionMS & 0xffff,
@@ skipping 13 matching lines @@
     case VFT_DLL:
       module_type = ModuleSnapshot::kModuleTypeSharedLibrary;
       break;
     default:
       module_type = ModuleSnapshot::kModuleTypeUnknown;
       break;
   }
   module_snapshot->SetModuleType(module_type);
 
   module_snapshot->SetUUIDAndAge(uuid, age);
+  module_snapshot->SetDebugFileName(pdb_name);
 }
 
 TEST(MinidumpModuleWriter, InitializeFromSnapshot) {
   MINIDUMP_MODULE expect_modules[3] = {};
   const char* module_paths[arraysize(expect_modules)] = {};
   const char* module_names[arraysize(expect_modules)] = {};
+  const char* module_pdbs[arraysize(expect_modules)] = {};
   UUID uuids[arraysize(expect_modules)] = {};
   uint32_t ages[arraysize(expect_modules)] = {};
 
   expect_modules[0].BaseOfImage = 0x100101000;
   expect_modules[0].SizeOfImage = 0xf000;
   expect_modules[0].TimeDateStamp = 0x01234567;
   expect_modules[0].VersionInfo.dwFileVersionMS = 0x00010002;
   expect_modules[0].VersionInfo.dwFileVersionLS = 0x00030004;
   expect_modules[0].VersionInfo.dwProductVersionMS = 0x00050006;
   expect_modules[0].VersionInfo.dwProductVersionLS = 0x00070008;
   expect_modules[0].VersionInfo.dwFileType = VFT_APP;
   module_paths[0] = "/usr/bin/true";
   module_names[0] = "true";
+  module_pdbs[0] = "true";
   const uint8_t kUUIDBytes0[16] =
       {0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77,
        0x88, 0x99, 0xaa, 0xbb, 0xcc, 0xdd, 0xee, 0xff};
   uuids[0].InitializeFromBytes(kUUIDBytes0);
   ages[0] = 10;
 
   expect_modules[1].BaseOfImage = 0x200202000;
   expect_modules[1].SizeOfImage = 0x1e1000;
   expect_modules[1].TimeDateStamp = 0x89abcdef;
   expect_modules[1].VersionInfo.dwFileVersionMS = 0x0009000a;
   expect_modules[1].VersionInfo.dwFileVersionLS = 0x000b000c;
   expect_modules[1].VersionInfo.dwProductVersionMS = 0x000d000e;
   expect_modules[1].VersionInfo.dwProductVersionLS = 0x000f0000;
   expect_modules[1].VersionInfo.dwFileType = VFT_DLL;
   module_paths[1] = "/usr/lib/libSystem.B.dylib";
   module_names[1] = "libSystem.B.dylib";
+  module_pdbs[1] = "libSystem.B.dylib.pdb";
   const uint8_t kUUIDBytes1[16] =
       {0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
        0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f};
   uuids[1].InitializeFromBytes(kUUIDBytes1);
   ages[1] = 20;
 
   expect_modules[2].BaseOfImage = 0x300303000;
   expect_modules[2].SizeOfImage = 0x2d000;
   expect_modules[2].TimeDateStamp = 0x76543210;
   expect_modules[2].VersionInfo.dwFileVersionMS = 0x11112222;
   expect_modules[2].VersionInfo.dwFileVersionLS = 0x33334444;
   expect_modules[2].VersionInfo.dwProductVersionMS = 0x9999aaaa;
   expect_modules[2].VersionInfo.dwProductVersionLS = 0xbbbbcccc;
   expect_modules[2].VersionInfo.dwFileType = VFT_UNKNOWN;
   module_paths[2] = "/usr/lib/dyld";
   module_names[2] = "dyld";
+  module_pdbs[2] = "/usr/lib/dyld.pdb";
   const uint8_t kUUIDBytes2[16] =
       {0xff, 0xfe, 0xfd, 0xfc, 0xfb, 0xfa, 0xf9, 0xf8,
        0xf7, 0xf6, 0xf5, 0xf4, 0xf3, 0xf2, 0xf1, 0xf0};
   uuids[2].InitializeFromBytes(kUUIDBytes2);
   ages[2] = 30;
 
   PointerVector<TestModuleSnapshot> module_snapshots_owner;
   std::vector<const ModuleSnapshot*> module_snapshots;
   for (size_t index = 0; index < arraysize(expect_modules); ++index) {
     TestModuleSnapshot* module_snapshot = new TestModuleSnapshot();
     module_snapshots_owner.push_back(module_snapshot);
     InitializeTestModuleSnapshotFromMinidumpModule(module_snapshot,
                                                    expect_modules[index],
                                                    module_paths[index],
+                                                   module_pdbs[index],
                                                    uuids[index],
                                                    ages[index]);
     module_snapshots.push_back(module_snapshot);
   }
 
   auto module_list_writer = make_scoped_ptr(new MinidumpModuleListWriter());
   module_list_writer->InitializeFromSnapshot(module_snapshots);
 
   MinidumpFileWriter minidump_file_writer;
   minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MODULE_LIST* module_list = nullptr;
   ASSERT_NO_FATAL_FAILURE(
       GetModuleListStream(string_file.string(), &module_list));
 
   ASSERT_EQ(3u, module_list->NumberOfModules);
 
   for (size_t index = 0; index < module_list->NumberOfModules; ++index) {
     SCOPED_TRACE(base::StringPrintf("index %" PRIuS, index));
     ASSERT_NO_FATAL_FAILURE(ExpectModule(&expect_modules[index],
                                          &module_list->Modules[index],
                                          string_file.string(),
                                          module_paths[index],
-                                         module_names[index],
+                                         module_pdbs[index],
                                          &uuids[index],
                                          0,
                                          ages[index],
                                          nullptr,
                                          0,
                                          false));
   }
 }
 
 TEST(MinidumpModuleWriterDeathTest, NoModuleName) {
   MinidumpFileWriter minidump_file_writer;
   auto module_list_writer = make_scoped_ptr(new MinidumpModuleListWriter());
   auto module_writer = make_scoped_ptr(new MinidumpModuleWriter());
   module_list_writer->AddModule(module_writer.Pass());
   minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFile string_file;
   ASSERT_DEATH_CHECK(minidump_file_writer.WriteEverything(&string_file),
                      "name_");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad