Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1415533018: Compile components/copresence/proto/enums.proto in Android. (Closed)

Created:
5 years, 1 month ago by Hadi
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile components/copresence/proto/enums.proto in Android. When we compile for android, g++ gets the flag "-DANDROID", and then pre-processor removes ANDROID from IdentifyType, which causes compile errors. To fix this, we change ANDROID to ANDROIDOS in IdentifyType. BUG=550158 Committed: https://crrev.com/5225817ff5148b23e012a0f7966cf679402c5d1a Cr-Commit-Position: refs/heads/master@{#357605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/copresence/proto/enums.proto View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Hadi
PTAL
5 years, 1 month ago (2015-11-01 16:19:46 UTC) #3
mfomitchev
LGTM
5 years, 1 month ago (2015-11-02 15:37:21 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-03 07:19:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415533018/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415533018/1
5 years, 1 month ago (2015-11-03 14:45:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/135234)
5 years, 1 month ago (2015-11-03 17:05:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415533018/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415533018/1
5 years, 1 month ago (2015-11-03 19:25:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 20:15:00 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 20:16:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5225817ff5148b23e012a0f7966cf679402c5d1a
Cr-Commit-Position: refs/heads/master@{#357605}

Powered by Google App Engine
This is Rietveld 408576698